This is an automated email from the ASF dual-hosted git repository. aherbert pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-geometry.git
commit e6d292dfc04d90f479dde9ad603ab22e38f0a3c7 Author: Alex Herbert <[email protected]> AuthorDate: Mon Sep 22 14:41:40 2025 +0100 pmd fix: remove unnecessary scope qualifier --- .../commons/geometry/euclidean/threed/AffineTransformMatrix3D.java | 2 +- .../java/org/apache/commons/geometry/euclidean/threed/Vector3D.java | 6 +++--- .../java/org/apache/commons/geometry/euclidean/twod/Vector2D.java | 6 +++--- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/AffineTransformMatrix3D.java b/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/AffineTransformMatrix3D.java index 9a396900..d214a9e7 100644 --- a/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/AffineTransformMatrix3D.java +++ b/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/AffineTransformMatrix3D.java @@ -626,7 +626,7 @@ public final class AffineTransformMatrix3D extends AbstractAffineTransformMatrix final Vector3D v = tPlusY.subtract(tZero); final Vector3D w = tPlusZ.subtract(tZero); - final AffineTransformMatrix3D mat = AffineTransformMatrix3D.fromColumnVectors(u, v, w, tZero); + final AffineTransformMatrix3D mat = fromColumnVectors(u, v, w, tZero); final double det = mat.determinant(); if (!Vectors.isRealNonZero(det)) { diff --git a/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/Vector3D.java b/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/Vector3D.java index 8795199c..4e8bad0e 100644 --- a/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/Vector3D.java +++ b/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/Vector3D.java @@ -571,7 +571,7 @@ public class Vector3D extends MultiDimensionalEuclideanVector<Vector3D> { z = Math.max(z, vec.getZ()); } - return Vector3D.of(x, y, z); + return of(x, y, z); } /** Return a vector containing the minimum component values from all input vectors. @@ -616,7 +616,7 @@ public class Vector3D extends MultiDimensionalEuclideanVector<Vector3D> { z = Math.min(z, vec.getZ()); } - return Vector3D.of(x, y, z); + return of(x, y, z); } /** Compute the centroid of the given points. The centroid is the arithmetic mean position of a set @@ -878,7 +878,7 @@ public class Vector3D extends MultiDimensionalEuclideanVector<Vector3D> { * @return new instance set to zero */ public static Sum create() { - return new Sum(Vector3D.ZERO); + return new Sum(ZERO); } /** Construct a new instance with an initial value set to the argument. diff --git a/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/twod/Vector2D.java b/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/twod/Vector2D.java index 013ad0e6..39e6b3c6 100644 --- a/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/twod/Vector2D.java +++ b/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/twod/Vector2D.java @@ -504,7 +504,7 @@ public class Vector2D extends MultiDimensionalEuclideanVector<Vector2D> { y = Math.max(y, vec.getY()); } - return Vector2D.of(x, y); + return of(x, y); } /** Return a vector containing the minimum component values from all input vectors. @@ -547,7 +547,7 @@ public class Vector2D extends MultiDimensionalEuclideanVector<Vector2D> { y = Math.min(y, vec.getY()); } - return Vector2D.of(x, y); + return of(x, y); } /** Compute the centroid of the given points. The centroid is the arithmetic mean position of a set @@ -793,7 +793,7 @@ public class Vector2D extends MultiDimensionalEuclideanVector<Vector2D> { * @return new instance set to zero */ public static Sum create() { - return new Sum(Vector2D.ZERO); + return new Sum(ZERO); } /** Construct a new instance with an initial value set to the argument.
