Author: sebb
Date: Fri Mar 11 15:03:45 2011
New Revision: 1080593
URL: http://svn.apache.org/viewvc?rev=1080593&view=rev
Log:
Use StringBuilder instead of String concatenation (Findbugs)
Modified:
commons/proper/net/trunk/src/main/java/org/apache/commons/net/smtp/AuthenticatingSMTPClient.java
Modified:
commons/proper/net/trunk/src/main/java/org/apache/commons/net/smtp/AuthenticatingSMTPClient.java
URL:
http://svn.apache.org/viewvc/commons/proper/net/trunk/src/main/java/org/apache/commons/net/smtp/AuthenticatingSMTPClient.java?rev=1080593&r1=1080592&r2=1080593&view=diff
==============================================================================
---
commons/proper/net/trunk/src/main/java/org/apache/commons/net/smtp/AuthenticatingSMTPClient.java
(original)
+++
commons/proper/net/trunk/src/main/java/org/apache/commons/net/smtp/AuthenticatingSMTPClient.java
Fri Mar 11 15:03:45 2011
@@ -223,13 +223,13 @@ public class AuthenticatingSMTPClient ex
*/
private String _convertToHexString(byte[] a)
{
- String result = "";
+ StringBuilder result = new StringBuilder(a.length*2);
for (int i = 0; i < a.length; i++)
{
- if ( (a[i] & 0x0FF) <= 15 ) result += "0";
- result += Integer.toHexString(a[i] & 0x0FF);
+ if ( (a[i] & 0x0FF) <= 15 ) result.append("0");
+ result.append(Integer.toHexString(a[i] & 0x0FF));
}
- return result;
+ return result.toString();
}
/**
