This is an automated email from the ASF dual-hosted git repository.
garydgregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-lang.git
The following commit(s) were added to refs/heads/master by this push:
new 5cef4ad00 Remove unused import
5cef4ad00 is described below
commit 5cef4ad0079b0a321a67df44467b95fa0fb96e8f
Author: Gary Gregory <[email protected]>
AuthorDate: Mon Jun 29 11:05:14 2026 +0000
Remove unused import
Sort members
---
.../org/apache/commons/lang3/StringUtilsTest.java | 1 -
.../apache/commons/lang3/math/NumberUtilsTest.java | 36 ++++++++++----------
.../apache/commons/lang3/text/WordUtilsTest.java | 38 +++++++++++-----------
3 files changed, 37 insertions(+), 38 deletions(-)
diff --git a/src/test/java/org/apache/commons/lang3/StringUtilsTest.java
b/src/test/java/org/apache/commons/lang3/StringUtilsTest.java
index c9090c513..76e9c7d72 100644
--- a/src/test/java/org/apache/commons/lang3/StringUtilsTest.java
+++ b/src/test/java/org/apache/commons/lang3/StringUtilsTest.java
@@ -39,7 +39,6 @@
import java.util.Iterator;
import java.util.List;
import java.util.Locale;
-import java.util.Objects;
import java.util.function.Supplier;
import java.util.regex.PatternSyntaxException;
diff --git a/src/test/java/org/apache/commons/lang3/math/NumberUtilsTest.java
b/src/test/java/org/apache/commons/lang3/math/NumberUtilsTest.java
index ae8a45c7a..5753d81a2 100644
--- a/src/test/java/org/apache/commons/lang3/math/NumberUtilsTest.java
+++ b/src/test/java/org/apache/commons/lang3/math/NumberUtilsTest.java
@@ -1308,24 +1308,6 @@ void testLang381() {
assertTrue(Float.isNaN(NumberUtils.max(bF)));
}
- @Test
- void testMinMaxSignedZero() {
- // The varargs overloads must agree with Math.min/Math.max (and the
three-argument
- // overloads, which delegate to them) on the sign of zero. -0.0 is
distinct from 0.0,
- // e.g. 1 / -0.0 is -Infinity, so the raw bits are asserted here.
- assertEquals(Double.doubleToRawLongBits(0.0d),
Double.doubleToRawLongBits(NumberUtils.max(-0.0d, 0.0d)));
- assertEquals(Double.doubleToRawLongBits(0.0d),
Double.doubleToRawLongBits(NumberUtils.max(0.0d, -0.0d)));
- assertEquals(Double.doubleToRawLongBits(-0.0d),
Double.doubleToRawLongBits(NumberUtils.min(-0.0d, 0.0d)));
- assertEquals(Double.doubleToRawLongBits(-0.0d),
Double.doubleToRawLongBits(NumberUtils.min(0.0d, -0.0d)));
- assertEquals(Float.floatToRawIntBits(0.0f),
Float.floatToRawIntBits(NumberUtils.max(-0.0f, 0.0f)));
- assertEquals(Float.floatToRawIntBits(0.0f),
Float.floatToRawIntBits(NumberUtils.max(0.0f, -0.0f)));
- assertEquals(Float.floatToRawIntBits(-0.0f),
Float.floatToRawIntBits(NumberUtils.min(-0.0f, 0.0f)));
- assertEquals(Float.floatToRawIntBits(-0.0f),
Float.floatToRawIntBits(NumberUtils.min(0.0f, -0.0f)));
- // the varargs result matches the three-argument overload
- assertEquals(Double.doubleToRawLongBits(NumberUtils.max(-0.0d, 0.0d,
0.0d)), Double.doubleToRawLongBits(NumberUtils.max(-0.0d, 0.0d)));
- assertEquals(Double.doubleToRawLongBits(NumberUtils.min(0.0d, -0.0d,
0.0d)), Double.doubleToRawLongBits(NumberUtils.min(0.0d, -0.0d)));
- }
-
@Test
void testLang747() {
assertEquals(Integer.valueOf(0x8000),
NumberUtils.createNumber("0x8000"));
@@ -1718,6 +1700,24 @@ void testMinLong_nullArray() {
assertNullPointerException(() -> NumberUtils.min((long[]) null));
}
+ @Test
+ void testMinMaxSignedZero() {
+ // The varargs overloads must agree with Math.min/Math.max (and the
three-argument
+ // overloads, which delegate to them) on the sign of zero. -0.0 is
distinct from 0.0,
+ // e.g. 1 / -0.0 is -Infinity, so the raw bits are asserted here.
+ assertEquals(Double.doubleToRawLongBits(0.0d),
Double.doubleToRawLongBits(NumberUtils.max(-0.0d, 0.0d)));
+ assertEquals(Double.doubleToRawLongBits(0.0d),
Double.doubleToRawLongBits(NumberUtils.max(0.0d, -0.0d)));
+ assertEquals(Double.doubleToRawLongBits(-0.0d),
Double.doubleToRawLongBits(NumberUtils.min(-0.0d, 0.0d)));
+ assertEquals(Double.doubleToRawLongBits(-0.0d),
Double.doubleToRawLongBits(NumberUtils.min(0.0d, -0.0d)));
+ assertEquals(Float.floatToRawIntBits(0.0f),
Float.floatToRawIntBits(NumberUtils.max(-0.0f, 0.0f)));
+ assertEquals(Float.floatToRawIntBits(0.0f),
Float.floatToRawIntBits(NumberUtils.max(0.0f, -0.0f)));
+ assertEquals(Float.floatToRawIntBits(-0.0f),
Float.floatToRawIntBits(NumberUtils.min(-0.0f, 0.0f)));
+ assertEquals(Float.floatToRawIntBits(-0.0f),
Float.floatToRawIntBits(NumberUtils.min(0.0f, -0.0f)));
+ // the varargs result matches the three-argument overload
+ assertEquals(Double.doubleToRawLongBits(NumberUtils.max(-0.0d, 0.0d,
0.0d)), Double.doubleToRawLongBits(NumberUtils.max(-0.0d, 0.0d)));
+ assertEquals(Double.doubleToRawLongBits(NumberUtils.min(0.0d, -0.0d,
0.0d)), Double.doubleToRawLongBits(NumberUtils.min(0.0d, -0.0d)));
+ }
+
@Test
void testMinShort() {
assertEquals((short) 5, NumberUtils.min((short) 5), "min(short[])
failed for array length 1");
diff --git a/src/test/java/org/apache/commons/lang3/text/WordUtilsTest.java
b/src/test/java/org/apache/commons/lang3/text/WordUtilsTest.java
index eed53b8ca..fe77a3765 100644
--- a/src/test/java/org/apache/commons/lang3/text/WordUtilsTest.java
+++ b/src/test/java/org/apache/commons/lang3/text/WordUtilsTest.java
@@ -140,6 +140,25 @@ void testCapitalizeWithDelimiters_String() {
assertEquals("I Am.fine", WordUtils.capitalize("i am.fine", null));
}
+ @Test
+ void testCase_SupplementaryCodePoint() {
+ // Deseret long-i: capital U+10400, small U+10428 (each a surrogate
pair)
+ final String cap = new String(Character.toChars(0x10400));
+ final String small = new String(Character.toChars(0x10428));
+
+ assertEquals(cap + "bc", WordUtils.capitalize(small + "bc"));
+ assertEquals("Ben " + cap + "ee", WordUtils.capitalize("ben " + small
+ "ee"));
+ assertEquals("Ben." + cap + "ee", WordUtils.capitalize("ben." + small
+ "ee", '.'));
+ assertEquals(cap + "bc", WordUtils.capitalizeFully(cap + "BC"));
+
+ assertEquals(small + "BC", WordUtils.uncapitalize(cap + "BC"));
+ assertEquals("a." + small + "BC", WordUtils.uncapitalize("a." + cap +
"BC", '.'));
+
+ assertEquals(small, WordUtils.swapCase(cap));
+ assertEquals(cap, WordUtils.swapCase(small));
+ assertEquals("A" + small, WordUtils.swapCase("a" + cap));
+ }
+
@Test
void testConstructor() {
assertNotNull(new WordUtils());
@@ -285,25 +304,6 @@ void testInitials_SupplementaryCodePoint() {
assertEquals("B" + emoji + "L", WordUtils.initials("Ben." + emoji +
"mile.Lee", '.'));
}
- @Test
- void testCase_SupplementaryCodePoint() {
- // Deseret long-i: capital U+10400, small U+10428 (each a surrogate
pair)
- final String cap = new String(Character.toChars(0x10400));
- final String small = new String(Character.toChars(0x10428));
-
- assertEquals(cap + "bc", WordUtils.capitalize(small + "bc"));
- assertEquals("Ben " + cap + "ee", WordUtils.capitalize("ben " + small
+ "ee"));
- assertEquals("Ben." + cap + "ee", WordUtils.capitalize("ben." + small
+ "ee", '.'));
- assertEquals(cap + "bc", WordUtils.capitalizeFully(cap + "BC"));
-
- assertEquals(small + "BC", WordUtils.uncapitalize(cap + "BC"));
- assertEquals("a." + small + "BC", WordUtils.uncapitalize("a." + cap +
"BC", '.'));
-
- assertEquals(small, WordUtils.swapCase(cap));
- assertEquals(cap, WordUtils.swapCase(small));
- assertEquals("A" + small, WordUtils.swapCase("a" + cap));
- }
-
@Test
void testLANG1292() {
// Prior to fix, this was throwing StringIndexOutOfBoundsException
