This is an automated email from the ASF dual-hosted git repository.
garydgregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-validator.git
The following commit(s) were added to refs/heads/master by this push:
new 8cd7a4fc Require the IPv6: tag for bracketed IPv6 email literals
(#428).
8cd7a4fc is described below
commit 8cd7a4fcdd82f10cbf12cf21deffe6088a189a9d
Author: Gary Gregory <[email protected]>
AuthorDate: Wed Jul 22 09:48:48 2026 -0400
Require the IPv6: tag for bracketed IPv6 email literals (#428).
Sort members
---
src/changes/changes.xml | 3 ++-
.../commons/validator/routines/EmailValidatorTest.java | 18 +++++++++---------
2 files changed, 11 insertions(+), 10 deletions(-)
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index 3b2155f8..27d7df84 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -108,7 +108,8 @@ The <action> type attribute can be add,update,fix,remove.
<action type="fix" dev="ggregory" due-to="sahvx655-wq, Gary
Gregory">Reject leading and trailing label hyphens in DomainValidator
unicodeToASCII (#424).</action>
<action type="fix" dev="ggregory" due-to="sahvx655-wq, Gary
Gregory">Reject over-length codes in ISSNCheckDigit (#426).</action>
<action type="fix" dev="ggregory" due-to="sahvx655-wq, Gary
Gregory">Reject fractional input in GenericTypeValidator integer helpers
(#423).</action>
- <action type="fix" dev="ggregory" due-to="sahvx655-wq, Gary
Gregory">Reject over-length codes in ABA, CUSIP, ISBN-10 and EAN-13 check
digits (#427)..</action>
+ <action type="fix" dev="ggregory" due-to="sahvx655-wq, Gary
Gregory">Reject over-length codes in ABA, CUSIP, ISBN-10 and EAN-13 check
digits (#427).</action>
+ <action type="fix" dev="ggregory" due-to="sahvx655-wq, Gary
Gregory">Require the IPv6: tag for bracketed IPv6 email literals
(#428).</action>
<!-- ADD -->
<action type="add" dev="ggregory" due-to="Gary Gregory">Add and use
CheckDigitException.CheckDigitException(String, Object...) (#389).</action>
<action type="add" dev="ggregory" due-to="Gary Gregory">Add and use
ValidatorException.ValidatorException(Throwable). Call sites that previously
called new ValidatorException(Throwable#getMessage()) now preserve that
exception (#390).</action>
diff --git
a/src/test/java/org/apache/commons/validator/routines/EmailValidatorTest.java
b/src/test/java/org/apache/commons/validator/routines/EmailValidatorTest.java
index 9ab3ddfd..7c5d2aed 100644
---
a/src/test/java/org/apache/commons/validator/routines/EmailValidatorTest.java
+++
b/src/test/java/org/apache/commons/validator/routines/EmailValidatorTest.java
@@ -444,15 +444,6 @@ public class EmailValidatorTest {
assertFalse(validator.isValid("[email protected]."));
}
- /**
- * Tests the email validation with numeric domains.
- */
- @Test
- void testEmailWithNumericAddress() {
- assertTrue(validator.isValid("someone@[216.109.118.76]"));
- assertTrue(validator.isValid("[email protected]"));
- }
-
/**
* Tests IPv6 address literals in the domain, which RFC 5321 section 4.1.3
tags with "IPv6:".
*/
@@ -470,6 +461,15 @@ public class EmailValidatorTest {
assertFalse(validator.isValid("someone@[IPv6:216.109.118.76]"));
}
+ /**
+ * Tests the email validation with numeric domains.
+ */
+ @Test
+ void testEmailWithNumericAddress() {
+ assertTrue(validator.isValid("someone@[216.109.118.76]"));
+ assertTrue(validator.isValid("[email protected]"));
+ }
+
/**
* VALIDATOR-296 - A / or a ! is valid in the user part, but not in the
domain part
*/
