This is an automated email from the ASF dual-hosted git repository.
garydgregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-compress.git
The following commit(s) were added to refs/heads/master by this push:
new 1875053b0 Add messages when throwing NullPointerException.
1875053b0 is described below
commit 1875053b01d20a1dc9a22f1e0424f097ba0b051d
Author: Gary Gregory <[email protected]>
AuthorDate: Wed Jul 22 11:05:59 2026 -0400
Add messages when throwing NullPointerException.
---
src/changes/changes.xml | 1 +
.../org/apache/commons/compress/archivers/ArchiveInputStream.java | 2 +-
.../org/apache/commons/compress/archivers/examples/Archiver.java | 8 ++++----
.../commons/compress/compressors/lz77support/LZ77Compressor.java | 2 +-
.../java/org/apache/commons/compress/harmony/pack200/CPClass.java | 2 +-
.../org/apache/commons/compress/harmony/pack200/CPString.java | 2 +-
src/main/java/org/apache/commons/compress/utils/Iterators.java | 4 ++--
7 files changed, 11 insertions(+), 10 deletions(-)
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index 3783873e6..3315aee4e 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -154,6 +154,7 @@ The <action> type attribute can be add,update,fix,remove.
<action type="fix" dev="ggregory" due-to="Gary Gregory">Pack200 class
IcBands.IcTuple implements equals() but not hashCode().</action>
<action type="fix" dev="ggregory" due-to="Martin Wiesner">Fix typos in
Javadoc and comments #761.</action>
<action type="fix" dev="ggregory" due-to="Gary
Gregory">org.apache.commons.compress.utils.ParsingUtils should set the cause of
the exceptions it throws.</action>
+ <action type="fix" dev="ggregory" due-to="Gary Gregory">Add messages
when throwing NullPointerException.</action>
<!-- ADD -->
<action type="add" dev="ggregory" due-to="Gary Gregory">Add
MemoryLimitException.MemoryLimitException(long, long).</action>
<action type="add" dev="ggregory" due-to="Gary Gregory">Add
CompressException.CompressException(String, Object...).</action>
diff --git
a/src/main/java/org/apache/commons/compress/archivers/ArchiveInputStream.java
b/src/main/java/org/apache/commons/compress/archivers/ArchiveInputStream.java
index a1bdbcbb7..f59f21a95 100644
---
a/src/main/java/org/apache/commons/compress/archivers/ArchiveInputStream.java
+++
b/src/main/java/org/apache/commons/compress/archivers/ArchiveInputStream.java
@@ -187,7 +187,7 @@ protected void count(final long read) {
* @since 1.27.0
*/
public void forEach(final IOConsumer<? super E> action) throws IOException
{
- iterator().forEachRemaining(Objects.requireNonNull(action));
+ iterator().forEachRemaining(Objects.requireNonNull(action, "action"));
}
/**
diff --git
a/src/main/java/org/apache/commons/compress/archivers/examples/Archiver.java
b/src/main/java/org/apache/commons/compress/archivers/examples/Archiver.java
index 64253507e..e316b6848 100644
--- a/src/main/java/org/apache/commons/compress/archivers/examples/Archiver.java
+++ b/src/main/java/org/apache/commons/compress/archivers/examples/Archiver.java
@@ -69,8 +69,8 @@ public FileVisitResult preVisitDirectory(final Path dir,
final BasicFileAttribut
}
protected FileVisitResult visit(final Path path, final
BasicFileAttributes attrs, final boolean isFile) throws IOException {
- Objects.requireNonNull(path);
- Objects.requireNonNull(attrs);
+ Objects.requireNonNull(path, "path");
+ Objects.requireNonNull(attrs, "attrs");
final String name =
directory.relativize(path).toString().replace('\\', '/');
if (!name.isEmpty()) {
final E archiveEntry = outputStream.createArchiveEntry(path,
isFile || name.endsWith("/") ? name : name + "/", linkOptions);
@@ -166,8 +166,8 @@ public void create(final SevenZOutputFile target, final
Path directory) throws I
@Override
protected FileVisitResult visit(final Path path, final
BasicFileAttributes attrs, final boolean isFile) throws IOException {
- Objects.requireNonNull(path);
- Objects.requireNonNull(attrs);
+ Objects.requireNonNull(path, "path");
+ Objects.requireNonNull(attrs, "attrs");
final String name =
directory.relativize(path).toString().replace('\\', '/');
if (!name.isEmpty()) {
final SevenZArchiveEntry archiveEntry =
target.createArchiveEntry(path, isFile || name.endsWith("/") ? name : name +
"/");
diff --git
a/src/main/java/org/apache/commons/compress/compressors/lz77support/LZ77Compressor.java
b/src/main/java/org/apache/commons/compress/compressors/lz77support/LZ77Compressor.java
index e3b5fe9e7..672ebca6d 100644
---
a/src/main/java/org/apache/commons/compress/compressors/lz77support/LZ77Compressor.java
+++
b/src/main/java/org/apache/commons/compress/compressors/lz77support/LZ77Compressor.java
@@ -192,7 +192,7 @@ public Block() {
* @param type The block type, may not be {@code null}.
*/
protected Block(final BlockType type) {
- this.type = Objects.requireNonNull(type);
+ this.type = Objects.requireNonNull(type, "type");
}
/**
diff --git
a/src/main/java/org/apache/commons/compress/harmony/pack200/CPClass.java
b/src/main/java/org/apache/commons/compress/harmony/pack200/CPClass.java
index 0f85beecc..62245d34a 100644
--- a/src/main/java/org/apache/commons/compress/harmony/pack200/CPClass.java
+++ b/src/main/java/org/apache/commons/compress/harmony/pack200/CPClass.java
@@ -37,7 +37,7 @@ public class CPClass extends CPConstant<CPClass> {
* @param value The value.
*/
public CPClass(final CPUTF8 value) {
- this.value = Objects.requireNonNull(value);
+ this.value = Objects.requireNonNull(value, "value");
this.className = value.getUnderlyingString();
final char[] chars = className.toCharArray();
for (final char element : chars) {
diff --git
a/src/main/java/org/apache/commons/compress/harmony/pack200/CPString.java
b/src/main/java/org/apache/commons/compress/harmony/pack200/CPString.java
index 3ae20a8c3..d82b329f8 100644
--- a/src/main/java/org/apache/commons/compress/harmony/pack200/CPString.java
+++ b/src/main/java/org/apache/commons/compress/harmony/pack200/CPString.java
@@ -36,7 +36,7 @@ public class CPString extends CPConstant<CPString> {
* @param value The value.
*/
public CPString(final CPUTF8 value) {
- this.value = Objects.requireNonNull(value);
+ this.value = Objects.requireNonNull(value, "value");
this.string = value.getUnderlyingString();
}
diff --git a/src/main/java/org/apache/commons/compress/utils/Iterators.java
b/src/main/java/org/apache/commons/compress/utils/Iterators.java
index 4dd8a4391..127ab8cd6 100644
--- a/src/main/java/org/apache/commons/compress/utils/Iterators.java
+++ b/src/main/java/org/apache/commons/compress/utils/Iterators.java
@@ -43,8 +43,8 @@ public class Iterators {
* @return {@code true} if the target {@code collection} was modified as a
result of this operation.
*/
public static <T> boolean addAll(final Collection<T> collection, final
Iterator<? extends T> iterator) {
- Objects.requireNonNull(collection);
- Objects.requireNonNull(iterator);
+ Objects.requireNonNull(collection, "collection");
+ Objects.requireNonNull(iterator, "iterator");
boolean wasModified = false;
while (iterator.hasNext()) {
wasModified |= collection.add(iterator.next());
