(commons-proxy) branch master updated: Better JUnit API usage

[ggregory]

This is an automated email from the ASF dual-hosted git repository.

garydgregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-proxy.git


The following commit(s) were added to refs/heads/master by this push:
     new 9ac21cc  Better JUnit API usage
9ac21cc is described below

commit 9ac21ccd4cd2fda225cb9ddc03b8e84de66f1bc7
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Mon Jul 27 15:05:00 2026 +0000

    Better JUnit API usage
---
 .../commons/proxy2/AbstractProxyFactoryTestCase.java     | 16 ++++++++++------
 .../proxy2/AbstractSubclassingProxyFactoryTestCase.java  | 12 ++++++------
 2 files changed, 16 insertions(+), 12 deletions(-)

diff --git 
a/core/src/test/java/org/apache/commons/proxy2/AbstractProxyFactoryTestCase.java
 
b/core/src/test/java/org/apache/commons/proxy2/AbstractProxyFactoryTestCase.java
index 363addf..20c62c1 100644
--- 
a/core/src/test/java/org/apache/commons/proxy2/AbstractProxyFactoryTestCase.java
+++ 
b/core/src/test/java/org/apache/commons/proxy2/AbstractProxyFactoryTestCase.java
@@ -19,6 +19,7 @@ package org.apache.commons.proxy2;
 
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertNotEquals;
 import static org.junit.Assert.assertNotNull;
 import static org.junit.Assert.assertNotSame;
 import static org.junit.Assert.assertSame;
@@ -36,6 +37,9 @@ import java.util.ServiceLoader;
 import java.util.SortedSet;
 import java.util.TreeSet;
 
+import 
org.apache.commons.proxy2.AbstractProxyFactoryTestCase.InterceptorTester;
+import org.apache.commons.proxy2.AbstractProxyFactoryTestCase.InvokerTester;
+import 
org.apache.commons.proxy2.AbstractProxyFactoryTestCase.NoOpMethodInterceptor;
 import org.apache.commons.proxy2.provider.BeanProvider;
 import org.apache.commons.proxy2.provider.ConstantProvider;
 import org.apache.commons.proxy2.provider.SingletonProvider;
@@ -113,8 +117,8 @@ public abstract class AbstractProxyFactoryTestCase extends 
AbstractTestCase
         final Comparable<?> proxy1 = factory.createInterceptorProxy(date, new 
NoOpMethodInterceptor(), COMPARABLE_ONLY);
         final Comparable<?> proxy2 = factory.createInterceptorProxy(date, new 
NoOpMethodInterceptor(), COMPARABLE_ONLY);
         assertEquals(proxy1, proxy1);
-        assertFalse(proxy1.equals(proxy2));
-        assertFalse(proxy2.equals(proxy1));
+        assertNotEquals(proxy1, proxy2);
+        assertNotEquals(proxy2, proxy1);
     }
 
     @Test
@@ -123,8 +127,8 @@ public abstract class AbstractProxyFactoryTestCase extends 
AbstractTestCase
         final Comparable<?> proxy1 = factory.createInvokerProxy(new 
InvokerTester(), COMPARABLE_ONLY);
         final Comparable<?> proxy2 = factory.createInvokerProxy(new 
InvokerTester(), COMPARABLE_ONLY);
         assertEquals(proxy1, proxy1);
-        assertFalse(proxy1.equals(proxy2));
-        assertFalse(proxy2.equals(proxy1));
+        assertNotEquals(proxy1, proxy2);
+        assertNotEquals(proxy2, proxy1);
     }
 
     @Test
@@ -134,8 +138,8 @@ public abstract class AbstractProxyFactoryTestCase extends 
AbstractTestCase
         final Comparable<?> proxy1 = factory.createDelegatorProxy(new 
ConstantProvider<Date>(date), COMPARABLE_ONLY);
         final Comparable<?> proxy2 = factory.createDelegatorProxy(new 
ConstantProvider<Date>(date), COMPARABLE_ONLY);
         assertEquals(proxy1, proxy1);
-        assertFalse(proxy1.equals(proxy2));
-        assertFalse(proxy2.equals(proxy1));
+        assertNotEquals(proxy1, proxy2);
+        assertNotEquals(proxy2, proxy1);
     }
 
     @Test
diff --git 
a/core/src/test/java/org/apache/commons/proxy2/AbstractSubclassingProxyFactoryTestCase.java
 
b/core/src/test/java/org/apache/commons/proxy2/AbstractSubclassingProxyFactoryTestCase.java
index 8cd7ff1..763e830 100644
--- 
a/core/src/test/java/org/apache/commons/proxy2/AbstractSubclassingProxyFactoryTestCase.java
+++ 
b/core/src/test/java/org/apache/commons/proxy2/AbstractSubclassingProxyFactoryTestCase.java
@@ -68,8 +68,8 @@ public abstract class AbstractSubclassingProxyFactoryTestCase 
extends AbstractPr
         final Echo proxy2 = factory.createDelegatorProxy(new 
ConstantProvider<Echo>(echo),
                 new Class[] { EqualsEcho.class });
         assertEquals(proxy1, proxy1);
-        assertFalse(proxy1.equals(proxy2));
-        assertFalse(proxy2.equals(proxy1));
+        assertNotEquals(proxy1, proxy2);
+        assertNotEquals(proxy2, proxy1);
     }
 
     @Test(expected = ProxyFactoryException.class)
@@ -97,8 +97,8 @@ public abstract class AbstractSubclassingProxyFactoryTestCase 
extends AbstractPr
         final Echo proxy2 = factory.createInterceptorProxy(echo, new 
NoOpMethodInterceptor(),
                 new Class[] { EqualsEcho.class });
         assertEquals(proxy1, proxy1);
-        assertFalse(proxy1.equals(proxy2));
-        assertFalse(proxy2.equals(proxy1));
+        assertNotEquals(proxy1, proxy2);
+        assertNotEquals(proxy2, proxy1);
     }
 
     @Test(expected = ProxyFactoryException.class)
@@ -129,8 +129,8 @@ public abstract class 
AbstractSubclassingProxyFactoryTestCase extends AbstractPr
         final Date proxy1 = factory.createInvokerProxy(new InvokerTester(), 
DATE_ONLY);
         final Date proxy2 = factory.createInvokerProxy(new InvokerTester(), 
DATE_ONLY);
         assertEquals(proxy1, proxy1);
-        assertFalse(proxy1.equals(proxy2));
-        assertFalse(proxy2.equals(proxy1));
+        assertNotEquals(proxy1, proxy2);
+        assertNotEquals(proxy2, proxy1);
     }
 
     @Test