This is an automated email from the ASF dual-hosted git repository.
garydgregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-text.git
The following commit(s) were added to refs/heads/master by this push:
new 8479d98d Better use of JUnit API.
8479d98d is described below
commit 8479d98d979de2dd819454061af08637c8781d50
Author: Gary Gregory <[email protected]>
AuthorDate: Mon Jul 27 15:20:25 2026 +0000
Better use of JUnit API.
---
src/test/java/org/apache/commons/text/AlphabetConverterTest.java | 7 ++++---
src/test/java/org/apache/commons/text/StrBuilderTest.java | 6 +++---
src/test/java/org/apache/commons/text/TextStringBuilderTest.java | 6 +++---
.../apache/commons/text/similarity/LevenshteinResultsTest.java | 9 +++++----
4 files changed, 15 insertions(+), 13 deletions(-)
diff --git a/src/test/java/org/apache/commons/text/AlphabetConverterTest.java
b/src/test/java/org/apache/commons/text/AlphabetConverterTest.java
index 7dabf1b2..b4ef8540 100644
--- a/src/test/java/org/apache/commons/text/AlphabetConverterTest.java
+++ b/src/test/java/org/apache/commons/text/AlphabetConverterTest.java
@@ -18,6 +18,7 @@ package org.apache.commons.text;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertNotEquals;
import static org.junit.jupiter.api.Assertions.assertNull;
import static org.junit.jupiter.api.Assertions.assertThrows;
import static org.junit.jupiter.api.Assertions.assertTrue;
@@ -121,7 +122,7 @@ class AlphabetConverterTest {
characterArray[1] = characterArray[0];
final AlphabetConverter alphabetConverter =
AlphabetConverter.createConverterFromChars(characterArray, characterArray,
characterArray);
- assertFalse(alphabetConverter.equals(charOne));
+ assertNotEquals(alphabetConverter, charOne);
}
@Test
@@ -150,7 +151,7 @@ class AlphabetConverterTest {
final AlphabetConverter alphabetConverter =
AlphabetConverter.createConverterFromMap(hashMap);
hashMap.put(0, "CtDs");
final AlphabetConverter alphabetConverterTwo =
AlphabetConverter.createConverterFromMap(hashMap);
- assertFalse(alphabetConverter.equals(alphabetConverterTwo));
+ assertNotEquals(alphabetConverter, alphabetConverterTwo);
assertEquals(1, alphabetConverter.getEncodedCharLength());
}
@@ -185,7 +186,7 @@ class AlphabetConverterTest {
final AlphabetConverter alphabetConverterTwo =
AlphabetConverter.createConverterFromMap(map);
assertEquals(1, alphabetConverterTwo.getEncodedCharLength());
- assertFalse(alphabetConverter.equals(alphabetConverterTwo));
+ assertNotEquals(alphabetConverter, alphabetConverterTwo);
}
@Test
diff --git a/src/test/java/org/apache/commons/text/StrBuilderTest.java
b/src/test/java/org/apache/commons/text/StrBuilderTest.java
index f112f106..4b4760a2 100644
--- a/src/test/java/org/apache/commons/text/StrBuilderTest.java
+++ b/src/test/java/org/apache/commons/text/StrBuilderTest.java
@@ -79,7 +79,7 @@ class StrBuilderTest {
void test_LANG_1131_EqualsWithNullStrBuilder() throws Exception {
final StrBuilder sb = new StrBuilder();
final StrBuilder other = null;
- assertFalse(sb.equals(other));
+ assertNotEquals(sb, other);
}
@Test
@@ -796,11 +796,11 @@ class StrBuilderTest {
assertEquals(sb1, (Object) sb2);
sb1.append("abc");
- assertFalse(sb1.equals(sb2));
+ assertNotEquals(sb1, sb2);
assertNotEquals(sb1, (Object) sb2);
sb2.append("ABC");
- assertFalse(sb1.equals(sb2));
+ assertNotEquals(sb1, sb2);
assertNotEquals(sb1, (Object) sb2);
sb2.clear().append("abc");
diff --git a/src/test/java/org/apache/commons/text/TextStringBuilderTest.java
b/src/test/java/org/apache/commons/text/TextStringBuilderTest.java
index 937d730e..edb45749 100644
--- a/src/test/java/org/apache/commons/text/TextStringBuilderTest.java
+++ b/src/test/java/org/apache/commons/text/TextStringBuilderTest.java
@@ -102,7 +102,7 @@ class TextStringBuilderTest {
void test_LANG_1131_EqualsWithNullTextStringBuilder() throws Exception {
final TextStringBuilder sb = new TextStringBuilder();
final TextStringBuilder other = null;
- assertFalse(sb.equals(other));
+ assertNotEquals(sb, other);
}
@Test
@@ -937,11 +937,11 @@ class TextStringBuilderTest {
assertEquals(sb1, sb2);
sb1.append("abc");
- assertFalse(sb1.equals(sb2));
+ assertNotEquals(sb1, sb2);
assertNotEquals(sb1, sb2);
sb2.append("ABC");
- assertFalse(sb1.equals(sb2));
+ assertNotEquals(sb1, sb2);
assertNotEquals(sb1, sb2);
sb2.set("abc");
diff --git
a/src/test/java/org/apache/commons/text/similarity/LevenshteinResultsTest.java
b/src/test/java/org/apache/commons/text/similarity/LevenshteinResultsTest.java
index d72f91f9..2c4c1835 100644
---
a/src/test/java/org/apache/commons/text/similarity/LevenshteinResultsTest.java
+++
b/src/test/java/org/apache/commons/text/similarity/LevenshteinResultsTest.java
@@ -17,6 +17,7 @@
package org.apache.commons.text.similarity;
import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertNotEquals;
import static org.junit.jupiter.api.Assertions.assertTrue;
import org.junit.jupiter.api.Test;
@@ -28,7 +29,7 @@ class LevenshteinResultsTest {
final Integer integer = 1662;
final LevenshteinResults levenshteinResults = new
LevenshteinResults(integer, integer, integer, integer);
final LevenshteinResults levenshteinResultsTwo = new
LevenshteinResults(integer, integer, integer, null);
- assertFalse(levenshteinResults.equals(levenshteinResultsTwo));
+ assertNotEquals(levenshteinResults, levenshteinResultsTwo);
}
@Test
@@ -37,7 +38,7 @@ class LevenshteinResultsTest {
final Integer integerTwo = 1164;
final LevenshteinResults levenshteinResults = new
LevenshteinResults(integerOne, integerOne, integerOne, integerOne);
final LevenshteinResults levenshteinResultsTwo = new
LevenshteinResults(integerTwo, integerOne, integerOne, integerOne);
- assertFalse(levenshteinResults.equals(levenshteinResultsTwo));
+ assertNotEquals(levenshteinResults, levenshteinResultsTwo);
}
@Test
@@ -46,7 +47,7 @@ class LevenshteinResultsTest {
final Integer integerTwo = 1164;
final LevenshteinResults levenshteinResults = new
LevenshteinResults(integerOne, integerOne, integerOne, integerOne);
final LevenshteinResults levenshteinResultsTwo = new
LevenshteinResults(integerOne, integerOne, integerTwo, integerTwo);
- assertFalse(levenshteinResults.equals(levenshteinResultsTwo));
+ assertNotEquals(levenshteinResults, levenshteinResultsTwo);
}
@Test
@@ -68,7 +69,7 @@ class LevenshteinResultsTest {
final Integer integer = 1;
final LevenshteinResults levenshteinResults = new
LevenshteinResults(null, integer, integer, null);
final LevenshteinResults levenshteinResultsTwo = new
LevenshteinResults(null, null, null, null);
- assertFalse(levenshteinResults.equals(levenshteinResultsTwo));
+ assertNotEquals(levenshteinResults, levenshteinResultsTwo);
}
@Test