This is an automated email from the ASF dual-hosted git repository. garydgregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-validator.git
commit 542a82a79c212515c4a8a92418597b428993b5a2 Author: Gary Gregory <[email protected]> AuthorDate: Thu Aug 27 10:42:16 2026 -0400 Sort members --- .../validator/routines/UrlValidatorTest.java | 32 +++++++++++----------- .../routines/checkdigit/SedolCheckDigitTest.java | 22 +++++++-------- 2 files changed, 27 insertions(+), 27 deletions(-) diff --git a/src/test/java/org/apache/commons/validator/routines/UrlValidatorTest.java b/src/test/java/org/apache/commons/validator/routines/UrlValidatorTest.java index 735fa294..7b247209 100644 --- a/src/test/java/org/apache/commons/validator/routines/UrlValidatorTest.java +++ b/src/test/java/org/apache/commons/validator/routines/UrlValidatorTest.java @@ -152,6 +152,22 @@ public class UrlValidatorTest { } } + @Test + void testFileSchemeCaseInsensitive() { + final String[] schemes = { "file" }; + final UrlValidator urlValidator = new UrlValidator(schemes, UrlValidator.ALLOW_LOCAL_URLS); + + // the scheme is case-insensitive, so an upper or mixed case file: URL is treated like the lower case form + assertTrue(urlValidator.isValid("file:///etc/hosts")); + assertTrue(urlValidator.isValid("FILE:///etc/hosts")); + assertTrue(urlValidator.isValid("File:///etc/hosts")); + + // a Windows drive letter in the authority is never valid, whatever the scheme case, and must not + // slip past the guard the lower case form is checked against + assertFalse(urlValidator.isValid("file://C:/some.file")); + assertFalse(urlValidator.isValid("FILE://C:/some.file")); + } + @Test void testFileSchemePath() { final String[] schemes = { "file" }; @@ -173,22 +189,6 @@ public class UrlValidatorTest { assertTrue(urlValidator.isValid("file:/C:/path/to/dir/")); } - @Test - void testFileSchemeCaseInsensitive() { - final String[] schemes = { "file" }; - final UrlValidator urlValidator = new UrlValidator(schemes, UrlValidator.ALLOW_LOCAL_URLS); - - // the scheme is case-insensitive, so an upper or mixed case file: URL is treated like the lower case form - assertTrue(urlValidator.isValid("file:///etc/hosts")); - assertTrue(urlValidator.isValid("FILE:///etc/hosts")); - assertTrue(urlValidator.isValid("File:///etc/hosts")); - - // a Windows drive letter in the authority is never valid, whatever the scheme case, and must not - // slip past the guard the lower case form is checked against - assertFalse(urlValidator.isValid("file://C:/some.file")); - assertFalse(urlValidator.isValid("FILE://C:/some.file")); - } - @Test void testFileSchemePathOptions() { final String[] schemes = { "file" }; diff --git a/src/test/java/org/apache/commons/validator/routines/checkdigit/SedolCheckDigitTest.java b/src/test/java/org/apache/commons/validator/routines/checkdigit/SedolCheckDigitTest.java index 18544366..3a1ec0d6 100644 --- a/src/test/java/org/apache/commons/validator/routines/checkdigit/SedolCheckDigitTest.java +++ b/src/test/java/org/apache/commons/validator/routines/checkdigit/SedolCheckDigitTest.java @@ -46,6 +46,17 @@ class SedolCheckDigitTest extends AbstractCheckDigitTest { zeroSum = "0000000"; } + /** + * A SEDOL is exactly seven characters, but a shorter string can carry a modulus 10 check digit by chance (for + * example "55", "550" and "5500" all weight to 20, and "0055" to 40), so the length must be enforced or isValid + * accepts it. + */ + @ParameterizedTest + @ValueSource(strings = { "55", "550", "5500", "0055" }) + void testUnderLengthRejected(final String code) { + assertFalse(routine.isValid(code), "Should fail (not seven characters): " + code); + } + @Test void testValidator346() { for (final String invalidCheckDigit : INVALID_CHECK_DIGITS) { @@ -64,15 +75,4 @@ class SedolCheckDigitTest extends AbstractCheckDigitTest { assertFalse(routine.isValid(code), "Should fail (contains a vowel): " + code); } - /** - * A SEDOL is exactly seven characters, but a shorter string can carry a modulus 10 check digit by chance (for - * example "55", "550" and "5500" all weight to 20, and "0055" to 40), so the length must be enforced or isValid - * accepts it. - */ - @ParameterizedTest - @ValueSource(strings = { "55", "550", "5500", "0055" }) - void testUnderLengthRejected(final String code) { - assertFalse(routine.isValid(code), "Should fail (not seven characters): " + code); - } - }
