This is an automated email from the ASF dual-hosted git repository. garydgregory pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/commons-xml.git
commit 9a3b5fed4a1c7e1fc1112fa683cc8e3c5db82a21 Author: Gary Gregory <[email protected]> AuthorDate: Fri Aug 28 13:39:05 2026 -0400 Rename test method. --- src/test/java/org/apache/commons/xml/AttackTestSupport.java | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/test/java/org/apache/commons/xml/AttackTestSupport.java b/src/test/java/org/apache/commons/xml/AttackTestSupport.java index 46c0722..7f75a7c 100644 --- a/src/test/java/org/apache/commons/xml/AttackTestSupport.java +++ b/src/test/java/org/apache/commons/xml/AttackTestSupport.java @@ -694,14 +694,14 @@ static void assertValidatorValidates(final String xml) { * <p>{@link XMLReader#parse(InputSource)} on a raw reader hardened via {@link SecureSAXParserFactory#secure(XMLReader)}; only a thrown exception passes.</p> */ static void assertXmlReaderBlocks(final String payload) { - assertParseFails(() -> consumeXmlReader(rawHardenedReader(), payload), "XMLReader", SAXException.class); + assertParseFails(() -> consumeXmlReader(rawSecureXMLReader(), payload), "XMLReader", SAXException.class); } /** * Asserts a hardened-in-place XMLReader parse either blocks at parse or completes without leaked content. See {@link #assertDomBlocksOrDoesNotLeak(String)}. */ static void assertXmlReaderBlocksOrDoesNotLeak(final String payload) { - assertNoLeakOrThrows(() -> captureCharacters(rawHardenedReader(), payload), "XMLReader", SAXException.class); + assertNoLeakOrThrows(() -> captureCharacters(rawSecureXMLReader(), payload), "XMLReader", SAXException.class); } /** @@ -711,7 +711,7 @@ static void assertXmlReaderBlocksOrDoesNotLeak(final String payload) { * guarantees the parse succeeds but never resolves the external resource.</p> */ static void assertXmlReaderDoesNotLeak(final String payload) { - assertNoLeakStrict(() -> captureCharacters(rawHardenedReader(), payload), "XMLReader"); + assertNoLeakStrict(() -> captureCharacters(rawSecureXMLReader(), payload), "XMLReader"); } /** @@ -721,7 +721,7 @@ static void assertXmlReaderDoesNotLeak(final String payload) { * payloads.</p> */ static void assertXmlReaderParses(final String payload) { - assertParseSucceeds(() -> consumeXmlReader(rawHardenedReader(), payload), "XMLReader"); + assertParseSucceeds(() -> consumeXmlReader(rawSecureXMLReader(), payload), "XMLReader"); } /** @@ -927,7 +927,7 @@ private static boolean probeDomResolvesInternalEntities() { } /** Builds a raw {@link XMLReader} from a deliberately permissive {@link SAXParserFactory} and hardens it via {@link SecureSAXParserFactory#secure(XMLReader)}. */ - private static XMLReader rawHardenedReader() throws Exception { + private static XMLReader rawSecureXMLReader() throws Exception { final SAXParserFactory factory = SAXParserFactory.newInstance(); if (!IS_ANDROID) { factory.setFeature(XMLConstants.FEATURE_SECURE_PROCESSING, false);
