(commons-bcel) branch master updated: Test only prints to the console when asked

[ggregory.apache.org via commits]

This is an automated email from the ASF dual-hosted git repository.

garydgregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-bcel.git


The following commit(s) were added to refs/heads/master by this push:
     new 22257525 Test only prints to the console when asked
22257525 is described below

commit 22257525701861add0a23fbe9659fb1fe9c4f7e2
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Sat Oct 31 07:07:50 2026 -0400

    Test only prints to the console when asked
    
    System properties:
    
    - bcel.print.JarNames
    - bcel.print.ClassNames
    
    PR shouldn't be needed as Java 1.1 classes are processed; local run
    with:
    
    mvn clean test -Dtest=JdkGenericDumpTest
    -DExtraJavaHomes='/Users/garygregory/test/jdk-1_1_8_16-solaris-i586/'
    -Dbcel.print.JarNames -Dbcel.print.ClassNames
---
 src/test/java/org/apache/bcel/generic/JdkGenericDumpTest.java | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/src/test/java/org/apache/bcel/generic/JdkGenericDumpTest.java 
b/src/test/java/org/apache/bcel/generic/JdkGenericDumpTest.java
index b003e69a..7a3c81a6 100644
--- a/src/test/java/org/apache/bcel/generic/JdkGenericDumpTest.java
+++ b/src/test/java/org/apache/bcel/generic/JdkGenericDumpTest.java
@@ -78,6 +78,9 @@ import org.junit.jupiter.params.provider.MethodSource;
  */
 class JdkGenericDumpTest {
 
+    private static final boolean PRINT_CLASS_NAME = 
Boolean.getBoolean("bcel.print.ClassNames");
+    private static final boolean PRINT_JAR_NAME = 
Boolean.getBoolean("bcel.print.JarNames");
+
     private static class ClassParserFilesVisitor extends 
SimpleFileVisitor<Path> {
 
         private final PathMatcher matcher;
@@ -159,14 +162,18 @@ class JdkGenericDumpTest {
     }
 
     private void testJar(final Path file) throws Exception {
-        System.out.println(file);
+        if (PRINT_JAR_NAME) {
+            System.out.println(" - " + file);
+        }
         try (JarFile jar = new JarFile(file.toFile())) {
             final Enumeration<JarEntry> en = jar.entries();
             while (en.hasMoreElements()) {
                 final JarEntry jarEntry = en.nextElement();
                 final String name = jarEntry.getName();
                 if (name.endsWith(JavaClass.EXTENSION)) {
-                    // System.out.println("- " + name);
+                    if (PRINT_CLASS_NAME) {
+                        System.out.println("  - " + name);
+                    }
                     try (InputStream inputStream = 
jar.getInputStream(jarEntry)) {
                         final ClassParser classParser = new 
ClassParser(inputStream, name);
                         final JavaClass javaClass = classParser.parse();