Author: ggregory Date: Sun Jul 10 17:50:21 2011 New Revision: 1144916 URL: http://svn.apache.org/viewvc?rev=1144916&view=rev Log: [LANG-715] CharSetUtils.squeeze() speedup.
Modified: commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/CharSetUtils.java Modified: commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/CharSetUtils.java URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/CharSetUtils.java?rev=1144916&r1=1144915&r2=1144916&view=diff ============================================================================== --- commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/CharSetUtils.java (original) +++ commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/CharSetUtils.java Sun Jul 10 17:50:21 2011 @@ -73,10 +73,9 @@ public class CharSetUtils { char ch = ' '; for (int i = 0; i < sz; i++) { ch = chrs[i]; - if (chars.contains(ch)) { - if ((ch == lastChar) && (i != 0)) { - continue; - } + // Compare with contains() last for performance. + if (ch == lastChar && i != 0 && chars.contains(ch)) { + continue; } buffer.append(ch); lastChar = ch;