Author: ggregory Date: Sun Jul 31 21:45:04 2011 New Revision: 1152651 URL: http://svn.apache.org/viewvc?rev=1152651&view=rev Log: Add edge case tests (which may not make sense, I need to check with Matthew)
Modified: commons/proper/codec/trunk/src/test/org/apache/commons/codec/language/bm/BeiderMorseEncoderTest.java Modified: commons/proper/codec/trunk/src/test/org/apache/commons/codec/language/bm/BeiderMorseEncoderTest.java URL: http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/test/org/apache/commons/codec/language/bm/BeiderMorseEncoderTest.java?rev=1152651&r1=1152650&r2=1152651&view=diff ============================================================================== --- commons/proper/codec/trunk/src/test/org/apache/commons/codec/language/bm/BeiderMorseEncoderTest.java (original) +++ commons/proper/codec/trunk/src/test/org/apache/commons/codec/language/bm/BeiderMorseEncoderTest.java Sun Jul 31 21:45:04 2011 @@ -25,6 +25,7 @@ import org.apache.commons.codec.EncoderE import org.apache.commons.codec.StringEncoder; import org.apache.commons.codec.StringEncoderAbstractTest; import org.junit.Assert; +import org.junit.Ignore; import org.junit.Test; /** @@ -34,11 +35,44 @@ import org.junit.Test; * @since 2.0 */ public class BeiderMorseEncoderTest extends StringEncoderAbstractTest { + private void assertNotEmpty(BeiderMorseEncoder bmpm, final String value) throws EncoderException { + Assert.assertFalse(value, bmpm.encode(value).equals("")); + } + @Override protected StringEncoder createStringEncoder() { return new BeiderMorseEncoder(); } + @Ignore + @Test + public void testAsciiEncodeNotEmpty1Letter() throws EncoderException { + BeiderMorseEncoder bmpm = new BeiderMorseEncoder(); + bmpm.setNameType(NameType.GENERIC); + bmpm.setRuleType(RuleType.APPROX); + for (char c = 'a'; c <= 'z'; c++) { + final String value = "" + c; + final String valueU = value.toUpperCase(); + assertNotEmpty(bmpm, value); + assertNotEmpty(bmpm, valueU); + } + } + + @Test + public void testAsciiEncodeNotEmpty2Letters() throws EncoderException { + BeiderMorseEncoder bmpm = new BeiderMorseEncoder(); + bmpm.setNameType(NameType.GENERIC); + bmpm.setRuleType(RuleType.APPROX); + for (char c1 = 'a'; c1 <= 'z'; c1++) { + for (char c2 = 'a'; c2 <= 'z'; c2++) { + final String value = new String(new char[] { c1, c2 }); + final String valueU = value.toUpperCase(); + assertNotEmpty(bmpm, value); + assertNotEmpty(bmpm, valueU); + } + } + } + @Test public void testEncodeAtzNotEmpty() throws EncoderException { BeiderMorseEncoder bmpm = new BeiderMorseEncoder(); @@ -46,7 +80,7 @@ public class BeiderMorseEncoderTest exte bmpm.setRuleType(RuleType.APPROX); String[] names = { "ácz", "átz", "Ignácz", "Ignátz", "Ignác" }; for (String name : names) { - Assert.assertFalse(bmpm.encode(name).equals("")); + assertNotEmpty(bmpm, name); } }