Author: ggregory Date: Sun Jan 13 04:39:40 2013 New Revision: 1432548 URL: http://svn.apache.org/viewvc?rev=1432548&view=rev Log: Add final modifier to private fields.
Modified: commons/proper/logging/trunk/src/test/org/apache/commons/logging/PathableTestSuite.java commons/proper/logging/trunk/src/test/org/apache/commons/logging/jdk14/TestHandler.java commons/proper/logging/trunk/src/test/org/apache/commons/logging/log4j/log4j12/TestAppender.java commons/proper/logging/trunk/src/test/org/apache/commons/logging/security/MockSecurityManager.java Modified: commons/proper/logging/trunk/src/test/org/apache/commons/logging/PathableTestSuite.java URL: http://svn.apache.org/viewvc/commons/proper/logging/trunk/src/test/org/apache/commons/logging/PathableTestSuite.java?rev=1432548&r1=1432547&r2=1432548&view=diff ============================================================================== --- commons/proper/logging/trunk/src/test/org/apache/commons/logging/PathableTestSuite.java (original) +++ commons/proper/logging/trunk/src/test/org/apache/commons/logging/PathableTestSuite.java Sun Jan 13 04:39:40 2013 @@ -109,7 +109,7 @@ public class PathableTestSuite extends T * The classloader that should be set as the context classloader * before each test in the suite is run. */ - private ClassLoader contextLoader; + private final ClassLoader contextLoader; /** * Constructor. Modified: commons/proper/logging/trunk/src/test/org/apache/commons/logging/jdk14/TestHandler.java URL: http://svn.apache.org/viewvc/commons/proper/logging/trunk/src/test/org/apache/commons/logging/jdk14/TestHandler.java?rev=1432548&r1=1432547&r2=1432548&view=diff ============================================================================== --- commons/proper/logging/trunk/src/test/org/apache/commons/logging/jdk14/TestHandler.java (original) +++ commons/proper/logging/trunk/src/test/org/apache/commons/logging/jdk14/TestHandler.java Sun Jan 13 04:39:40 2013 @@ -39,7 +39,7 @@ public class TestHandler extends Handler // The set of logged records for this handler - private List records = new ArrayList(); + private final List records = new ArrayList(); // --------------------------------------------------------- Public Methods Modified: commons/proper/logging/trunk/src/test/org/apache/commons/logging/log4j/log4j12/TestAppender.java URL: http://svn.apache.org/viewvc/commons/proper/logging/trunk/src/test/org/apache/commons/logging/log4j/log4j12/TestAppender.java?rev=1432548&r1=1432547&r2=1432548&view=diff ============================================================================== --- commons/proper/logging/trunk/src/test/org/apache/commons/logging/log4j/log4j12/TestAppender.java (original) +++ commons/proper/logging/trunk/src/test/org/apache/commons/logging/log4j/log4j12/TestAppender.java Sun Jan 13 04:39:40 2013 @@ -44,7 +44,7 @@ public class TestAppender extends Append // The set of logged events for this appender - private List events; + private final List events; // ------------------------------------------------------- Appender Methods Modified: commons/proper/logging/trunk/src/test/org/apache/commons/logging/security/MockSecurityManager.java URL: http://svn.apache.org/viewvc/commons/proper/logging/trunk/src/test/org/apache/commons/logging/security/MockSecurityManager.java?rev=1432548&r1=1432547&r2=1432548&view=diff ============================================================================== --- commons/proper/logging/trunk/src/test/org/apache/commons/logging/security/MockSecurityManager.java (original) +++ commons/proper/logging/trunk/src/test/org/apache/commons/logging/security/MockSecurityManager.java Sun Jan 13 04:39:40 2013 @@ -30,7 +30,7 @@ import java.security.Permissions; */ public class MockSecurityManager extends SecurityManager { - private Permissions permissions = new Permissions(); + private final Permissions permissions = new Permissions(); private static final Permission setSecurityManagerPerm = new RuntimePermission("setSecurityManager");