Repository: commons-io
Updated Branches:
  refs/heads/master b498cda5b -> 276b28257


Refactor magic string into a constant.

Project: http://git-wip-us.apache.org/repos/asf/commons-io/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-io/commit/276b2825
Tree: http://git-wip-us.apache.org/repos/asf/commons-io/tree/276b2825
Diff: http://git-wip-us.apache.org/repos/asf/commons-io/diff/276b2825

Branch: refs/heads/master
Commit: 276b2825778c0f6286ead1dac0dfe5fca307e77a
Parents: b498cda
Author: Gary Gregory <garydgreg...@gmail.com>
Authored: Tue Mar 6 14:36:14 2018 -0700
Committer: Gary Gregory <garydgreg...@gmail.com>
Committed: Tue Mar 6 14:36:14 2018 -0700

----------------------------------------------------------------------
 .../java/org/apache/commons/io/input/ReversedLinesFileReader.java | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/commons-io/blob/276b2825/src/main/java/org/apache/commons/io/input/ReversedLinesFileReader.java
----------------------------------------------------------------------
diff --git 
a/src/main/java/org/apache/commons/io/input/ReversedLinesFileReader.java 
b/src/main/java/org/apache/commons/io/input/ReversedLinesFileReader.java
index 4fe9b46..9470f02 100644
--- a/src/main/java/org/apache/commons/io/input/ReversedLinesFileReader.java
+++ b/src/main/java/org/apache/commons/io/input/ReversedLinesFileReader.java
@@ -35,6 +35,7 @@ import org.apache.commons.io.Charsets;
  */
 public class ReversedLinesFileReader implements Closeable {
 
+    private static final String EMPTY_STRING = "";
     private static final int DEFAULT_BLOCK_SIZE = 4096;
     
     private final int blockSize;
@@ -187,7 +188,7 @@ public class ReversedLinesFileReader implements Closeable {
         }
 
         // aligned behaviour with BufferedReader that doesn't return a last, 
empty line
-        if("".equals(line) && !trailingNewlineOfFileSkipped) {
+        if(EMPTY_STRING.equals(line) && !trailingNewlineOfFileSkipped) {
             trailingNewlineOfFileSkipped = true;
             line = readLine();
         }

Reply via email to