Add final. Project: http://git-wip-us.apache.org/repos/asf/commons-text/repo Commit: http://git-wip-us.apache.org/repos/asf/commons-text/commit/937d9dac Tree: http://git-wip-us.apache.org/repos/asf/commons-text/tree/937d9dac Diff: http://git-wip-us.apache.org/repos/asf/commons-text/diff/937d9dac
Branch: refs/heads/release Commit: 937d9dac2b43f839d2414c2074c90032ec1f6fbc Parents: ab8f6bd Author: Gary Gregory <garydgreg...@gmail.com> Authored: Fri Jun 1 15:54:26 2018 -0600 Committer: Gary Gregory <garydgreg...@gmail.com> Committed: Fri Jun 1 15:54:26 2018 -0600 ---------------------------------------------------------------------- .../java/org/apache/commons/text/lookup/StringLookupFactory.java | 2 +- src/test/java/org/apache/commons/text/StringEscapeUtilsTest.java | 4 ++-- .../org/apache/commons/text/diff/ReplacementsFinderTest.java | 2 +- .../text/similarity/ParameterizedEditDistanceFromTest.java | 2 +- .../text/similarity/ParameterizedLevenshteinDistanceTest.java | 2 +- .../text/similarity/ParameterizedSimilarityScoreFromTest.java | 2 +- 6 files changed, 7 insertions(+), 7 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/commons-text/blob/937d9dac/src/main/java/org/apache/commons/text/lookup/StringLookupFactory.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/text/lookup/StringLookupFactory.java b/src/main/java/org/apache/commons/text/lookup/StringLookupFactory.java index 92e3499..5d59d24 100644 --- a/src/main/java/org/apache/commons/text/lookup/StringLookupFactory.java +++ b/src/main/java/org/apache/commons/text/lookup/StringLookupFactory.java @@ -144,7 +144,7 @@ public final class StringLookupFactory { * @return a new InterpolatorStringLookup. * @since 1.4 */ - public StringLookup interpolatorStringLookup(Map<String, StringLookup> stringLookupMap, + public StringLookup interpolatorStringLookup(final Map<String, StringLookup> stringLookupMap, final StringLookup defaultStringLookup, final boolean addDefaultLookups) { return new InterpolatorStringLookup(stringLookupMap, defaultStringLookup, addDefaultLookups); } http://git-wip-us.apache.org/repos/asf/commons-text/blob/937d9dac/src/test/java/org/apache/commons/text/StringEscapeUtilsTest.java ---------------------------------------------------------------------- diff --git a/src/test/java/org/apache/commons/text/StringEscapeUtilsTest.java b/src/test/java/org/apache/commons/text/StringEscapeUtilsTest.java index e1e10f6..2d36c13 100644 --- a/src/test/java/org/apache/commons/text/StringEscapeUtilsTest.java +++ b/src/test/java/org/apache/commons/text/StringEscapeUtilsTest.java @@ -628,8 +628,8 @@ public class StringEscapeUtilsTest { @Test // TEXT-120 public void testUnescapeJsonDoubleQuoteAndForwardSlash() { - String escapedJsonString = "double quote: \\\" and a forward slash: \\/"; - String jsonString = "double quote: \" and a forward slash: /"; + final String escapedJsonString = "double quote: \\\" and a forward slash: \\/"; + final String jsonString = "double quote: \" and a forward slash: /"; assertEquals(jsonString, StringEscapeUtils.unescapeJson(escapedJsonString)); } http://git-wip-us.apache.org/repos/asf/commons-text/blob/937d9dac/src/test/java/org/apache/commons/text/diff/ReplacementsFinderTest.java ---------------------------------------------------------------------- diff --git a/src/test/java/org/apache/commons/text/diff/ReplacementsFinderTest.java b/src/test/java/org/apache/commons/text/diff/ReplacementsFinderTest.java index 27f6160..8331cb1 100644 --- a/src/test/java/org/apache/commons/text/diff/ReplacementsFinderTest.java +++ b/src/test/java/org/apache/commons/text/diff/ReplacementsFinderTest.java @@ -59,7 +59,7 @@ public class ReplacementsFinderTest { @ParameterizedTest @MethodSource("parameters") - public void testReplacementsHandler(String left, String right, int skipped, Character[] from, Character[] to) { + public void testReplacementsHandler(final String left, final String right, final int skipped, final Character[] from, final Character[] to) { final StringsComparator sc = new StringsComparator(left, right); final ReplacementsFinder<Character> replacementFinder = new ReplacementsFinder<>(handler); sc.getScript().visit(replacementFinder); http://git-wip-us.apache.org/repos/asf/commons-text/blob/937d9dac/src/test/java/org/apache/commons/text/similarity/ParameterizedEditDistanceFromTest.java ---------------------------------------------------------------------- diff --git a/src/test/java/org/apache/commons/text/similarity/ParameterizedEditDistanceFromTest.java b/src/test/java/org/apache/commons/text/similarity/ParameterizedEditDistanceFromTest.java index 721439b..7873827 100644 --- a/src/test/java/org/apache/commons/text/similarity/ParameterizedEditDistanceFromTest.java +++ b/src/test/java/org/apache/commons/text/similarity/ParameterizedEditDistanceFromTest.java @@ -60,7 +60,7 @@ public class ParameterizedEditDistanceFromTest<R> { @ParameterizedTest @MethodSource("parameters") - public void test(EditDistance<R> editDistance, CharSequence left, CharSequence right, R distance) { + public void test(final EditDistance<R> editDistance, final CharSequence left, final CharSequence right, final R distance) { final EditDistanceFrom<R> editDistanceFrom = new EditDistanceFrom<>(editDistance, left); assertThat(editDistanceFrom.apply(right)).isEqualTo(distance); } http://git-wip-us.apache.org/repos/asf/commons-text/blob/937d9dac/src/test/java/org/apache/commons/text/similarity/ParameterizedLevenshteinDistanceTest.java ---------------------------------------------------------------------- diff --git a/src/test/java/org/apache/commons/text/similarity/ParameterizedLevenshteinDistanceTest.java b/src/test/java/org/apache/commons/text/similarity/ParameterizedLevenshteinDistanceTest.java index 3189ca3..8ef683b 100644 --- a/src/test/java/org/apache/commons/text/similarity/ParameterizedLevenshteinDistanceTest.java +++ b/src/test/java/org/apache/commons/text/similarity/ParameterizedLevenshteinDistanceTest.java @@ -95,7 +95,7 @@ public class ParameterizedLevenshteinDistanceTest { @ParameterizedTest @MethodSource("parameters") - public void test(Integer threshold, CharSequence left, CharSequence right, Integer distance) { + public void test(final Integer threshold, final CharSequence left, final CharSequence right, final Integer distance) { final LevenshteinDistance metric = new LevenshteinDistance(threshold); assertThat(metric.apply(left, right)).isEqualTo(distance); } http://git-wip-us.apache.org/repos/asf/commons-text/blob/937d9dac/src/test/java/org/apache/commons/text/similarity/ParameterizedSimilarityScoreFromTest.java ---------------------------------------------------------------------- diff --git a/src/test/java/org/apache/commons/text/similarity/ParameterizedSimilarityScoreFromTest.java b/src/test/java/org/apache/commons/text/similarity/ParameterizedSimilarityScoreFromTest.java index 9e30bed..91ee641 100644 --- a/src/test/java/org/apache/commons/text/similarity/ParameterizedSimilarityScoreFromTest.java +++ b/src/test/java/org/apache/commons/text/similarity/ParameterizedSimilarityScoreFromTest.java @@ -52,7 +52,7 @@ public class ParameterizedSimilarityScoreFromTest<R> { @ParameterizedTest @MethodSource("parameters") - public void test(SimilarityScore<R> similarityScore, CharSequence left, CharSequence right, R distance) { + public void test(final SimilarityScore<R> similarityScore, final CharSequence left, final CharSequence right, final R distance) { final SimilarityScoreFrom<R> similarityScoreFrom = new SimilarityScoreFrom<>(similarityScore, left); assertThat(similarityScoreFrom.apply(right)).isEqualTo(distance); }
