This is an automated email from the ASF dual-hosted git repository. erans pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-numbers.git
commit bf6de4fc369986130ac6f77d3d3c41dfe39a23cc Author: Eitan Adler <[email protected]> AuthorDate: Sun Jun 9 22:32:13 2019 -0700 Fix stragglers --- .../apache/commons/numbers/fraction/BigFractionTest.java | 14 +++++++------- .../apache/commons/numbers/fraction/FractionTest.java | 16 ++++++++-------- 2 files changed, 15 insertions(+), 15 deletions(-) diff --git a/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/BigFractionTest.java b/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/BigFractionTest.java index 81a0c0a..539c624 100644 --- a/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/BigFractionTest.java +++ b/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/BigFractionTest.java @@ -596,22 +596,22 @@ public class BigFractionTest { public void testEqualsAndHashCode() { BigFraction zero = BigFraction.of(0, 1); BigFraction nullFraction = null; - Assert.assertEquals(zero, zero); - Assert.assertNotEquals(zero, nullFraction); - Assert.assertNotEquals(zero, Double.valueOf(0), 0.0); + Assertions.assertEquals(zero, zero); + Assertions.assertNotEquals(nullFraction, zero); + Assertions.assertNotEquals(0.0d, zero); BigFraction zero2 = BigFraction.of(0, 2); - Assert.assertEquals(zero, zero2); + Assertions.assertEquals(zero, zero2); Assertions.assertEquals(zero.hashCode(), zero2.hashCode()); BigFraction one = BigFraction.of(1, 1); Assertions.assertFalse((one.equals(zero) || zero.equals(one))); - Assert.assertEquals(one, BigFraction.ONE); + Assertions.assertEquals(BigFraction.ONE, one); } @Test public void testGetReducedFraction() { BigFraction threeFourths = BigFraction.of(3, 4); - Assert.assertEquals(threeFourths, BigFraction.getReducedFraction(6, 8)); - Assert.assertEquals(BigFraction.ZERO, BigFraction.getReducedFraction(0, -1)); + Assertions.assertEquals(threeFourths, BigFraction.getReducedFraction(6, 8)); + Assertions.assertEquals(BigFraction.ZERO, BigFraction.getReducedFraction(0, -1)); try { BigFraction.getReducedFraction(1, 0); Assertions.fail("expecting ArithmeticException"); diff --git a/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/FractionTest.java b/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/FractionTest.java index d36ffaa..05a777f 100644 --- a/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/FractionTest.java +++ b/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/FractionTest.java @@ -247,11 +247,11 @@ public class FractionTest { public void testMath1261() { final Fraction a = Fraction.of(Integer.MAX_VALUE, 2); final Fraction b = a.multiply(2); - Assert.assertEquals(b, Fraction.of(Integer.MAX_VALUE)); + Assertions.assertEquals(b, Fraction.of(Integer.MAX_VALUE)); final Fraction c = Fraction.of(2, Integer.MAX_VALUE); final Fraction d = c.divide(2); - Assert.assertEquals(d, Fraction.of(1, Integer.MAX_VALUE)); + Assertions.assertEquals(d, Fraction.of(1, Integer.MAX_VALUE)); } @Test @@ -583,11 +583,11 @@ public class FractionTest { public void testEqualsAndHashCode() { Fraction zero = Fraction.of(0,1); Fraction nullFraction = null; - Assert.assertEquals(zero, zero); - Assert.assertNotEquals(zero, nullFraction); - Assert.assertNotEquals(zero, Double.valueOf(0), 0.0); + Assertions.assertEquals(zero, zero); + Assertions.assertNotEquals(nullFraction, zero); + Assertions.assertNotEquals(0.0, zero); Fraction zero2 = Fraction.of(0,2); - Assert.assertEquals(zero, zero2); + Assertions.assertEquals(zero, zero2); Assertions.assertEquals(zero.hashCode(), zero2.hashCode()); Fraction one = Fraction.of(1,1); Assertions.assertFalse((one.equals(zero) ||zero.equals(one))); @@ -596,8 +596,8 @@ public class FractionTest { @Test public void testGetReducedFraction() { Fraction threeFourths = Fraction.of(3, 4); - Assert.assertEquals(threeFourths, Fraction.getReducedFraction(6, 8)); - Assert.assertEquals(Fraction.ZERO, Fraction.getReducedFraction(0, -1)); + Assertions.assertEquals(threeFourths, Fraction.getReducedFraction(6, 8)); + Assertions.assertEquals(Fraction.ZERO, Fraction.getReducedFraction(0, -1)); try { Fraction.getReducedFraction(1, 0); Assertions.fail("expecting ArithmeticException");
