This is an automated email from the ASF dual-hosted git repository.

pascalschumacher pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-lang.git


The following commit(s) were added to refs/heads/master by this push:
     new ff05749  Conversion#binaryToHexDigit(boolean[], int): Simplify 
implementation by removing redundant conditions.
ff05749 is described below

commit ff05749cdc68fae72f12fcb6e06d41a4528ea4b6
Author: pascalschumacher <pascalschumac...@gmx.net>
AuthorDate: Sun Dec 22 12:42:16 2019 +0100

    Conversion#binaryToHexDigit(boolean[], int): Simplify implementation by 
removing redundant conditions.
---
 src/main/java/org/apache/commons/lang3/Conversion.java | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/main/java/org/apache/commons/lang3/Conversion.java 
b/src/main/java/org/apache/commons/lang3/Conversion.java
index de48081..18873d9 100644
--- a/src/main/java/org/apache/commons/lang3/Conversion.java
+++ b/src/main/java/org/apache/commons/lang3/Conversion.java
@@ -311,19 +311,19 @@ public class Conversion {
             throw new IllegalArgumentException("Cannot convert an empty 
array.");
         }
         if (src.length > srcPos + 3 && src[srcPos + 3]) {
-            if (src.length > srcPos + 2 && src[srcPos + 2]) {
-                if (src.length > srcPos + 1 && src[srcPos + 1]) {
+            if (src[srcPos + 2]) {
+                if (src[srcPos + 1]) {
                     return src[srcPos] ? 'f' : 'e';
                 }
                 return src[srcPos] ? 'd' : 'c';
             }
-            if (src.length > srcPos + 1 && src[srcPos + 1]) {
+            if (src[srcPos + 1]) {
                 return src[srcPos] ? 'b' : 'a';
             }
             return src[srcPos] ? '9' : '8';
         }
         if (src.length > srcPos + 2 && src[srcPos + 2]) {
-            if (src.length > srcPos + 1 && src[srcPos + 1]) {
+            if (src[srcPos + 1]) {
                 return src[srcPos] ? '7' : '6';
             }
             return src[srcPos] ? '5' : '4';

Reply via email to