This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-collections.git
The following commit(s) were added to refs/heads/master by this push:
new e7f0d13 Initialize a collection when you create it.
e7f0d13 is described below
commit e7f0d1372fdd72f38736116d7ba52eb15c4dca14
Author: Gary Gregory <[email protected]>
AuthorDate: Fri Nov 20 15:52:44 2020 -0500
Initialize a collection when you create it.
---
.../org/apache/commons/collections4/AbstractLinkedListTest.java | 4 +---
.../java/org/apache/commons/collections4/CollectionUtilsTest.java | 6 ++----
.../java/org/apache/commons/collections4/FluentIterableTest.java | 6 ++----
.../java/org/apache/commons/collections4/IteratorUtilsTest.java | 3 +--
.../commons/collections4/collection/AbstractCollectionTest.java | 6 ++----
.../commons/collections4/collection/IndexedCollectionTest.java | 8 ++------
.../collections4/collection/SynchronizedCollectionTest.java | 4 +---
.../collection/UnmodifiableBoundedCollectionTest.java | 4 +---
.../collections4/collection/UnmodifiableCollectionTest.java | 7 ++-----
.../org/apache/commons/collections4/list/AbstractListTest.java | 4 +---
.../org/apache/commons/collections4/list/FixedSizeListTest.java | 3 +--
.../java/org/apache/commons/collections4/list/GrowthListTest.java | 3 +--
.../org/apache/commons/collections4/list/TransformedListTest.java | 7 ++-----
.../apache/commons/collections4/list/UnmodifiableListTest.java | 3 +--
.../org/apache/commons/collections4/queue/AbstractQueueTest.java | 7 ++-----
.../apache/commons/collections4/queue/PredicatedQueueTest.java | 6 ++----
.../apache/commons/collections4/queue/TransformedQueueTest.java | 7 ++-----
.../apache/commons/collections4/queue/UnmodifiableQueueTest.java | 7 ++-----
.../commons/collections4/set/PredicatedNavigableSetTest.java | 3 +--
.../apache/commons/collections4/set/PredicatedSortedSetTest.java | 3 +--
.../commons/collections4/set/TransformedNavigableSetTest.java | 3 +--
.../org/apache/commons/collections4/set/TransformedSetTest.java | 7 ++-----
.../apache/commons/collections4/set/TransformedSortedSetTest.java | 3 +--
.../commons/collections4/set/UnmodifiableNavigableSetTest.java | 3 +--
.../org/apache/commons/collections4/set/UnmodifiableSetTest.java | 3 +--
.../commons/collections4/set/UnmodifiableSortedSetTest.java | 3 +--
26 files changed, 37 insertions(+), 86 deletions(-)
diff --git
a/src/test/java/org/apache/commons/collections4/AbstractLinkedListTest.java
b/src/test/java/org/apache/commons/collections4/AbstractLinkedListTest.java
index acaf9dc..ac8bc43 100644
--- a/src/test/java/org/apache/commons/collections4/AbstractLinkedListTest.java
+++ b/src/test/java/org/apache/commons/collections4/AbstractLinkedListTest.java
@@ -214,8 +214,6 @@ public abstract class AbstractLinkedListTest<T> extends
AbstractListTest<T> {
*/
@Override
public Collection<T> makeConfirmedFullCollection() {
- final List<T> list = new LinkedList<>();
- list.addAll(Arrays.asList(getFullElements()));
- return list;
+ return new LinkedList<>(Arrays.asList(getFullElements()));
}
}
diff --git
a/src/test/java/org/apache/commons/collections4/CollectionUtilsTest.java
b/src/test/java/org/apache/commons/collections4/CollectionUtilsTest.java
index 4922a91..4cb5590 100644
--- a/src/test/java/org/apache/commons/collections4/CollectionUtilsTest.java
+++ b/src/test/java/org/apache/commons/collections4/CollectionUtilsTest.java
@@ -2127,8 +2127,7 @@ public class CollectionUtilsTest extends MockTestCase {
List<Integer> result2 = CollectionUtils.collate(collectionE,
collectionD);
assertEquals("Merge two lists 1", result1, result2);
- final List<Integer> combinedList = new ArrayList<>();
- combinedList.addAll(collectionD);
+ final List<Integer> combinedList = new ArrayList<>(collectionD);
combinedList.addAll(collectionE);
Collections.sort(combinedList);
@@ -2156,8 +2155,7 @@ public class CollectionUtilsTest extends MockTestCase {
final List<Integer> result2 = CollectionUtils.collate(collectionE,
collectionD, false);
assertEquals("Merge two lists 1 - ignore duplicates", result1,
result2);
- final Set<Integer> combinedSet = new HashSet<>();
- combinedSet.addAll(collectionD);
+ final Set<Integer> combinedSet = new HashSet<>(collectionD);
combinedSet.addAll(collectionE);
final List<Integer> combinedList = new ArrayList<>(combinedSet);
Collections.sort(combinedList);
diff --git
a/src/test/java/org/apache/commons/collections4/FluentIterableTest.java
b/src/test/java/org/apache/commons/collections4/FluentIterableTest.java
index 4b72777..62c72cf 100644
--- a/src/test/java/org/apache/commons/collections4/FluentIterableTest.java
+++ b/src/test/java/org/apache/commons/collections4/FluentIterableTest.java
@@ -422,8 +422,7 @@ public class FluentIterableTest {
@Test
public void eval() {
- final List<Integer> listNumbers = new ArrayList<>();
- listNumbers.addAll(Arrays.asList(1, 2, 3, 4, 5, 6, 7, 8, 9, 10));
+ final List<Integer> listNumbers = new ArrayList<>(Arrays.asList(1, 2,
3, 4, 5, 6, 7, 8, 9, 10));
final FluentIterable<Integer> iterable =
FluentIterable.of(listNumbers).filter(EVEN);
final FluentIterable<Integer> materialized = iterable.eval();
@@ -458,8 +457,7 @@ public class FluentIterableTest {
result.add(8);
FluentIterable.of(iterableA).copyInto(result);
- expected = new ArrayList<>();
- expected.addAll(Arrays.asList(10, 9, 8));
+ expected = new ArrayList<>(Arrays.asList(10, 9, 8));
expected.addAll(IterableUtils.toList(iterableA));
assertEquals(expected.size(), result.size());
assertEquals(expected, result);
diff --git
a/src/test/java/org/apache/commons/collections4/IteratorUtilsTest.java
b/src/test/java/org/apache/commons/collections4/IteratorUtilsTest.java
index 4065df0..e72d23c 100644
--- a/src/test/java/org/apache/commons/collections4/IteratorUtilsTest.java
+++ b/src/test/java/org/apache/commons/collections4/IteratorUtilsTest.java
@@ -576,8 +576,7 @@ public class IteratorUtilsTest {
List<Integer> result = IteratorUtils.toList(it);
assertEquals(12, result.size());
- final List<Integer> combinedList = new ArrayList<>();
- combinedList.addAll(collectionOdd);
+ final List<Integer> combinedList = new ArrayList<>(collectionOdd);
combinedList.addAll(collectionEven);
Collections.sort(combinedList);
diff --git
a/src/test/java/org/apache/commons/collections4/collection/AbstractCollectionTest.java
b/src/test/java/org/apache/commons/collections4/collection/AbstractCollectionTest.java
index 2ef8725..1b5a0d2 100644
---
a/src/test/java/org/apache/commons/collections4/collection/AbstractCollectionTest.java
+++
b/src/test/java/org/apache/commons/collections4/collection/AbstractCollectionTest.java
@@ -392,8 +392,7 @@ public abstract class AbstractCollectionTest<E> extends
AbstractObjectTest {
@SuppressWarnings("unchecked")
public E[] getFullElements() {
if (isNullSupported()) {
- final ArrayList<E> list = new ArrayList<>();
- list.addAll(Arrays.asList(getFullNonNullElements()));
+ final ArrayList<E> list = new
ArrayList<>(Arrays.asList(getFullNonNullElements()));
list.add(4, null);
return (E[]) list.toArray();
}
@@ -710,8 +709,7 @@ public abstract class AbstractCollectionTest<E> extends
AbstractObjectTest {
// make sure calls to "containsAll" don't change anything
verify();
- col = new ArrayList<>();
- col.addAll(Arrays.asList(getFullElements()));
+ col = new ArrayList<>(Arrays.asList(getFullElements()));
col.addAll(Arrays.asList(getFullElements()));
assertTrue("Full collection should containAll duplicate full elements",
getCollection().containsAll(col));
diff --git
a/src/test/java/org/apache/commons/collections4/collection/IndexedCollectionTest.java
b/src/test/java/org/apache/commons/collections4/collection/IndexedCollectionTest.java
index be8704b..ac996fd 100644
---
a/src/test/java/org/apache/commons/collections4/collection/IndexedCollectionTest.java
+++
b/src/test/java/org/apache/commons/collections4/collection/IndexedCollectionTest.java
@@ -80,16 +80,12 @@ public class IndexedCollectionTest extends
AbstractCollectionTest<String> {
@Override
public Collection<String> makeFullCollection() {
- final List<String> list = new ArrayList<>();
- list.addAll(Arrays.asList(getFullElements()));
- return decorateCollection(list);
+ return decorateCollection(new
ArrayList<>(Arrays.asList(getFullElements())));
}
@Override
public Collection<String> makeConfirmedFullCollection() {
- final List<String> list = new ArrayList<>();
- list.addAll(Arrays.asList(getFullElements()));
- return list;
+ return new ArrayList<>(Arrays.asList(getFullElements()));
}
public Collection<String> makeTestCollection() {
diff --git
a/src/test/java/org/apache/commons/collections4/collection/SynchronizedCollectionTest.java
b/src/test/java/org/apache/commons/collections4/collection/SynchronizedCollectionTest.java
index 7b27ccf..7237484 100644
---
a/src/test/java/org/apache/commons/collections4/collection/SynchronizedCollectionTest.java
+++
b/src/test/java/org/apache/commons/collections4/collection/SynchronizedCollectionTest.java
@@ -45,9 +45,7 @@ public class SynchronizedCollectionTest<E> extends
AbstractCollectionTest<E> {
@Override
public Collection<E> makeConfirmedFullCollection() {
- final ArrayList<E> list = new ArrayList<>();
- list.addAll(Arrays.asList(getFullElements()));
- return list;
+ return new ArrayList<>(Arrays.asList(getFullElements()));
}
@Override
diff --git
a/src/test/java/org/apache/commons/collections4/collection/UnmodifiableBoundedCollectionTest.java
b/src/test/java/org/apache/commons/collections4/collection/UnmodifiableBoundedCollectionTest.java
index 11cb110..872b69f 100644
---
a/src/test/java/org/apache/commons/collections4/collection/UnmodifiableBoundedCollectionTest.java
+++
b/src/test/java/org/apache/commons/collections4/collection/UnmodifiableBoundedCollectionTest.java
@@ -56,9 +56,7 @@ public class UnmodifiableBoundedCollectionTest<E> extends
AbstractCollectionTest
@Override
public Collection<E> makeConfirmedFullCollection() {
- final ArrayList<E> list = new ArrayList<>();
- list.addAll(Arrays.asList(getFullElements()));
- return list;
+ return new ArrayList<>(Arrays.asList(getFullElements()));
}
@Override
diff --git
a/src/test/java/org/apache/commons/collections4/collection/UnmodifiableCollectionTest.java
b/src/test/java/org/apache/commons/collections4/collection/UnmodifiableCollectionTest.java
index d8c8600..e50f034 100644
---
a/src/test/java/org/apache/commons/collections4/collection/UnmodifiableCollectionTest.java
+++
b/src/test/java/org/apache/commons/collections4/collection/UnmodifiableCollectionTest.java
@@ -43,8 +43,7 @@ public class UnmodifiableCollectionTest<E> extends
AbstractCollectionTest<E> {
@Override
public Collection<E> makeFullCollection() {
- final List<E> list = new ArrayList<>();
- list.addAll(Arrays.asList(getFullElements()));
+ final List<E> list = new ArrayList<>(Arrays.asList(getFullElements()));
return UnmodifiableCollection.unmodifiableCollection(list);
}
@@ -55,9 +54,7 @@ public class UnmodifiableCollectionTest<E> extends
AbstractCollectionTest<E> {
@Override
public Collection<E> makeConfirmedFullCollection() {
- final ArrayList<E> list = new ArrayList<>();
- list.addAll(Arrays.asList(getFullElements()));
- return list;
+ return new ArrayList<>(Arrays.asList(getFullElements()));
}
@Override
diff --git
a/src/test/java/org/apache/commons/collections4/list/AbstractListTest.java
b/src/test/java/org/apache/commons/collections4/list/AbstractListTest.java
index bc54cd4..a061195 100644
--- a/src/test/java/org/apache/commons/collections4/list/AbstractListTest.java
+++ b/src/test/java/org/apache/commons/collections4/list/AbstractListTest.java
@@ -128,9 +128,7 @@ public abstract class AbstractListTest<E> extends
AbstractCollectionTest<E> {
*/
@Override
public Collection<E> makeConfirmedFullCollection() {
- final ArrayList<E> list = new ArrayList<>();
- list.addAll(Arrays.asList(getFullElements()));
- return list;
+ return new ArrayList<>(Arrays.asList(getFullElements()));
}
/**
diff --git
a/src/test/java/org/apache/commons/collections4/list/FixedSizeListTest.java
b/src/test/java/org/apache/commons/collections4/list/FixedSizeListTest.java
index a4f60f9..0a036b8 100644
--- a/src/test/java/org/apache/commons/collections4/list/FixedSizeListTest.java
+++ b/src/test/java/org/apache/commons/collections4/list/FixedSizeListTest.java
@@ -41,8 +41,7 @@ public class FixedSizeListTest<E> extends AbstractListTest<E>
{
@Override
public List<E> makeFullCollection() {
- final List<E> list = new ArrayList<>();
- list.addAll(Arrays.asList(getFullElements()));
+ final List<E> list = new ArrayList<>(Arrays.asList(getFullElements()));
return FixedSizeList.fixedSizeList(list);
}
diff --git
a/src/test/java/org/apache/commons/collections4/list/GrowthListTest.java
b/src/test/java/org/apache/commons/collections4/list/GrowthListTest.java
index 61f5f65..7f8d63c 100644
--- a/src/test/java/org/apache/commons/collections4/list/GrowthListTest.java
+++ b/src/test/java/org/apache/commons/collections4/list/GrowthListTest.java
@@ -39,8 +39,7 @@ public class GrowthListTest<E> extends AbstractListTest<E> {
@Override
public List<E> makeFullCollection() {
- final List<E> list = new ArrayList<>();
- list.addAll(Arrays.asList(getFullElements()));
+ final List<E> list = new ArrayList<>(Arrays.asList(getFullElements()));
return GrowthList.growthList(list);
}
diff --git
a/src/test/java/org/apache/commons/collections4/list/TransformedListTest.java
b/src/test/java/org/apache/commons/collections4/list/TransformedListTest.java
index 1ef1596..2a104f7 100644
---
a/src/test/java/org/apache/commons/collections4/list/TransformedListTest.java
+++
b/src/test/java/org/apache/commons/collections4/list/TransformedListTest.java
@@ -43,9 +43,7 @@ public class TransformedListTest<E> extends
AbstractListTest<E> {
@Override
public List<E> makeConfirmedFullCollection() {
- final List<E> list = new ArrayList<>();
- list.addAll(Arrays.asList(getFullElements()));
- return list;
+ return new ArrayList<>(Arrays.asList(getFullElements()));
}
@Override
@@ -57,8 +55,7 @@ public class TransformedListTest<E> extends
AbstractListTest<E> {
@Override
@SuppressWarnings("unchecked")
public List<E> makeFullCollection() {
- final List<E> list = new ArrayList<>();
- list.addAll(Arrays.asList(getFullElements()));
+ final List<E> list = new ArrayList<>(Arrays.asList(getFullElements()));
return TransformedList.transformingList(list, (Transformer<E, E>)
TransformedCollectionTest.NOOP_TRANSFORMER);
}
diff --git
a/src/test/java/org/apache/commons/collections4/list/UnmodifiableListTest.java
b/src/test/java/org/apache/commons/collections4/list/UnmodifiableListTest.java
index 670f175..a15fcd2 100644
---
a/src/test/java/org/apache/commons/collections4/list/UnmodifiableListTest.java
+++
b/src/test/java/org/apache/commons/collections4/list/UnmodifiableListTest.java
@@ -41,8 +41,7 @@ public class UnmodifiableListTest<E> extends
AbstractListTest<E> {
@Override
public UnmodifiableList<E> makeFullCollection() {
- final ArrayList<E> list = new ArrayList<>();
- list.addAll(Arrays.asList(getFullElements()));
+ final ArrayList<E> list = new
ArrayList<>(Arrays.asList(getFullElements()));
return new UnmodifiableList<>(list);
}
diff --git
a/src/test/java/org/apache/commons/collections4/queue/AbstractQueueTest.java
b/src/test/java/org/apache/commons/collections4/queue/AbstractQueueTest.java
index e2eaaab..17148e0 100644
--- a/src/test/java/org/apache/commons/collections4/queue/AbstractQueueTest.java
+++ b/src/test/java/org/apache/commons/collections4/queue/AbstractQueueTest.java
@@ -86,8 +86,7 @@ public abstract class AbstractQueueTest<E> extends
AbstractCollectionTest<E> {
*/
@Override
public Collection<E> makeConfirmedCollection() {
- final ArrayList<E> list = new ArrayList<>();
- return list;
+ return new ArrayList<>();
}
/**
@@ -95,9 +94,7 @@ public abstract class AbstractQueueTest<E> extends
AbstractCollectionTest<E> {
*/
@Override
public Collection<E> makeConfirmedFullCollection() {
- final ArrayList<E> list = new ArrayList<>();
- list.addAll(Arrays.asList(getFullElements()));
- return list;
+ return new ArrayList<>(Arrays.asList(getFullElements()));
}
/**
diff --git
a/src/test/java/org/apache/commons/collections4/queue/PredicatedQueueTest.java
b/src/test/java/org/apache/commons/collections4/queue/PredicatedQueueTest.java
index fb50d6f..e365b3f 100644
---
a/src/test/java/org/apache/commons/collections4/queue/PredicatedQueueTest.java
+++
b/src/test/java/org/apache/commons/collections4/queue/PredicatedQueueTest.java
@@ -53,8 +53,7 @@ public class PredicatedQueueTest<E> extends
AbstractQueueTest<E> {
@Override
public Queue<E> makeFullCollection() {
- final Queue<E> queue = new LinkedList<>();
- queue.addAll(Arrays.asList(getFullElements()));
+ final Queue<E> queue = new
LinkedList<>(Arrays.asList(getFullElements()));
return decorateCollection(queue, truePredicate);
}
@@ -65,8 +64,7 @@ public class PredicatedQueueTest<E> extends
AbstractQueueTest<E> {
@Override
public Collection<E> makeConfirmedFullCollection() {
- final List<E> list = new LinkedList<>();
- list.addAll(Arrays.asList(getFullElements()));
+ final List<E> list = new
LinkedList<>(Arrays.asList(getFullElements()));
return list;
}
diff --git
a/src/test/java/org/apache/commons/collections4/queue/TransformedQueueTest.java
b/src/test/java/org/apache/commons/collections4/queue/TransformedQueueTest.java
index 5c6ba65..da27c0c 100644
---
a/src/test/java/org/apache/commons/collections4/queue/TransformedQueueTest.java
+++
b/src/test/java/org/apache/commons/collections4/queue/TransformedQueueTest.java
@@ -45,9 +45,7 @@ public class TransformedQueueTest<E> extends
AbstractQueueTest<E> {
@Override
public Queue<E> makeConfirmedFullCollection() {
- final Queue<E> list = new LinkedList<>();
- list.addAll(Arrays.asList(getFullElements()));
- return list;
+ return new LinkedList<>(Arrays.asList(getFullElements()));
}
@Override
@@ -60,8 +58,7 @@ public class TransformedQueueTest<E> extends
AbstractQueueTest<E> {
@Override
@SuppressWarnings("unchecked")
public Queue<E> makeFullCollection() {
- final Queue<E> list = new LinkedList<>();
- list.addAll(Arrays.asList(getFullElements()));
+ final Queue<E> list = new
LinkedList<>(Arrays.asList(getFullElements()));
return TransformedQueue.transformingQueue(list, (Transformer<E, E>)
TransformedCollectionTest.NOOP_TRANSFORMER);
}
diff --git
a/src/test/java/org/apache/commons/collections4/queue/UnmodifiableQueueTest.java
b/src/test/java/org/apache/commons/collections4/queue/UnmodifiableQueueTest.java
index 8bfe133..3b9b1b2 100644
---
a/src/test/java/org/apache/commons/collections4/queue/UnmodifiableQueueTest.java
+++
b/src/test/java/org/apache/commons/collections4/queue/UnmodifiableQueueTest.java
@@ -44,8 +44,7 @@ public class UnmodifiableQueueTest<E> extends
AbstractQueueTest<E> {
@Override
public Queue<E> makeFullCollection() {
- final Queue<E> queue = new LinkedList<>();
- queue.addAll(Arrays.asList(getFullElements()));
+ final Queue<E> queue = new
LinkedList<>(Arrays.asList(getFullElements()));
return UnmodifiableQueue.unmodifiableQueue(queue);
}
@@ -56,9 +55,7 @@ public class UnmodifiableQueueTest<E> extends
AbstractQueueTest<E> {
@Override
public Collection<E> makeConfirmedFullCollection() {
- final LinkedList<E> list = new LinkedList<>();
- list.addAll(Arrays.asList(getFullElements()));
- return list;
+ return new LinkedList<>(Arrays.asList(getFullElements()));
}
@Override
diff --git
a/src/test/java/org/apache/commons/collections4/set/PredicatedNavigableSetTest.java
b/src/test/java/org/apache/commons/collections4/set/PredicatedNavigableSetTest.java
index c0a1c66..0beaaeb 100644
---
a/src/test/java/org/apache/commons/collections4/set/PredicatedNavigableSetTest.java
+++
b/src/test/java/org/apache/commons/collections4/set/PredicatedNavigableSetTest.java
@@ -55,8 +55,7 @@ public class PredicatedNavigableSetTest<E> extends
AbstractNavigableSetTest<E> {
@Override
public NavigableSet<E> makeFullCollection() {
- final TreeSet<E> set = new TreeSet<>();
- set.addAll(Arrays.asList(getFullElements()));
+ final TreeSet<E> set = new TreeSet<>(Arrays.asList(getFullElements()));
return PredicatedNavigableSet.predicatedNavigableSet(set,
truePredicate);
}
diff --git
a/src/test/java/org/apache/commons/collections4/set/PredicatedSortedSetTest.java
b/src/test/java/org/apache/commons/collections4/set/PredicatedSortedSetTest.java
index adb041f..a06217e 100644
---
a/src/test/java/org/apache/commons/collections4/set/PredicatedSortedSetTest.java
+++
b/src/test/java/org/apache/commons/collections4/set/PredicatedSortedSetTest.java
@@ -53,8 +53,7 @@ public class PredicatedSortedSetTest<E> extends
AbstractSortedSetTest<E> {
@Override
public SortedSet<E> makeFullCollection() {
- final TreeSet<E> set = new TreeSet<>();
- set.addAll(Arrays.asList(getFullElements()));
+ final TreeSet<E> set = new TreeSet<>(Arrays.asList(getFullElements()));
return PredicatedSortedSet.predicatedSortedSet(set, truePredicate);
}
diff --git
a/src/test/java/org/apache/commons/collections4/set/TransformedNavigableSetTest.java
b/src/test/java/org/apache/commons/collections4/set/TransformedNavigableSetTest.java
index dd5d2b4..5efca86 100644
---
a/src/test/java/org/apache/commons/collections4/set/TransformedNavigableSetTest.java
+++
b/src/test/java/org/apache/commons/collections4/set/TransformedNavigableSetTest.java
@@ -55,8 +55,7 @@ public class TransformedNavigableSetTest<E> extends
AbstractNavigableSetTest<E>
@Override
@SuppressWarnings("unchecked")
public NavigableSet<E> makeFullCollection() {
- final NavigableSet<E> set = new TreeSet<>();
- set.addAll(Arrays.asList(getFullElements()));
+ final NavigableSet<E> set = new
TreeSet<>(Arrays.asList(getFullElements()));
return TransformedNavigableSet.transformingNavigableSet(set,
(Transformer<E, E>)
TransformedCollectionTest.NOOP_TRANSFORMER);
}
diff --git
a/src/test/java/org/apache/commons/collections4/set/TransformedSetTest.java
b/src/test/java/org/apache/commons/collections4/set/TransformedSetTest.java
index fcd9851..582a36a 100644
--- a/src/test/java/org/apache/commons/collections4/set/TransformedSetTest.java
+++ b/src/test/java/org/apache/commons/collections4/set/TransformedSetTest.java
@@ -43,9 +43,7 @@ public class TransformedSetTest<E> extends AbstractSetTest<E>
{
@Override
public Set<E> makeConfirmedFullCollection() {
- final Set<E> set = new HashSet<>();
- set.addAll(Arrays.asList(getFullElements()));
- return set;
+ return new HashSet<>(Arrays.asList(getFullElements()));
}
@Override
@@ -58,8 +56,7 @@ public class TransformedSetTest<E> extends AbstractSetTest<E>
{
@Override
@SuppressWarnings("unchecked")
public Set<E> makeFullCollection() {
- final Set<E> list = new HashSet<>();
- list.addAll(Arrays.asList(getFullElements()));
+ final Set<E> list = new HashSet<>(Arrays.asList(getFullElements()));
return TransformedSet.transformingSet(list,
(Transformer<E, E>)
TransformedCollectionTest.NOOP_TRANSFORMER);
}
diff --git
a/src/test/java/org/apache/commons/collections4/set/TransformedSortedSetTest.java
b/src/test/java/org/apache/commons/collections4/set/TransformedSortedSetTest.java
index bb31aa2..6c66718 100644
---
a/src/test/java/org/apache/commons/collections4/set/TransformedSortedSetTest.java
+++
b/src/test/java/org/apache/commons/collections4/set/TransformedSortedSetTest.java
@@ -54,8 +54,7 @@ public class TransformedSortedSetTest<E> extends
AbstractSortedSetTest<E> {
@Override
@SuppressWarnings("unchecked")
public SortedSet<E> makeFullCollection() {
- final SortedSet<E> set = new TreeSet<>();
- set.addAll(Arrays.asList(getFullElements()));
+ final SortedSet<E> set = new
TreeSet<>(Arrays.asList(getFullElements()));
return TransformedSortedSet.transformingSortedSet(set, (Transformer<E,
E>) TransformedCollectionTest.NOOP_TRANSFORMER);
}
diff --git
a/src/test/java/org/apache/commons/collections4/set/UnmodifiableNavigableSetTest.java
b/src/test/java/org/apache/commons/collections4/set/UnmodifiableNavigableSetTest.java
index 4d0d7c6..acbc080 100644
---
a/src/test/java/org/apache/commons/collections4/set/UnmodifiableNavigableSetTest.java
+++
b/src/test/java/org/apache/commons/collections4/set/UnmodifiableNavigableSetTest.java
@@ -53,8 +53,7 @@ public class UnmodifiableNavigableSetTest<E> extends
AbstractNavigableSetTest<E>
@Override
public UnmodifiableNavigableSet<E> makeFullCollection() {
- final TreeSet<E> set = new TreeSet<>();
- set.addAll(Arrays.asList(getFullElements()));
+ final TreeSet<E> set = new TreeSet<>(Arrays.asList(getFullElements()));
return (UnmodifiableNavigableSet<E>)
UnmodifiableNavigableSet.unmodifiableNavigableSet(set);
}
diff --git
a/src/test/java/org/apache/commons/collections4/set/UnmodifiableSetTest.java
b/src/test/java/org/apache/commons/collections4/set/UnmodifiableSetTest.java
index 795124a..ee27faa 100644
--- a/src/test/java/org/apache/commons/collections4/set/UnmodifiableSetTest.java
+++ b/src/test/java/org/apache/commons/collections4/set/UnmodifiableSetTest.java
@@ -49,8 +49,7 @@ public class UnmodifiableSetTest<E> extends
AbstractSetTest<E> {
@Override
public Set<E> makeFullCollection() {
- final HashSet<E> set = new HashSet<>();
- set.addAll(Arrays.asList(getFullElements()));
+ final HashSet<E> set = new HashSet<>(Arrays.asList(getFullElements()));
return UnmodifiableSet.unmodifiableSet(set);
}
diff --git
a/src/test/java/org/apache/commons/collections4/set/UnmodifiableSortedSetTest.java
b/src/test/java/org/apache/commons/collections4/set/UnmodifiableSortedSetTest.java
index ebdfbc7..96d185f 100644
---
a/src/test/java/org/apache/commons/collections4/set/UnmodifiableSortedSetTest.java
+++
b/src/test/java/org/apache/commons/collections4/set/UnmodifiableSortedSetTest.java
@@ -53,8 +53,7 @@ public class UnmodifiableSortedSetTest<E> extends
AbstractSortedSetTest<E> {
@Override
public UnmodifiableSortedSet<E> makeFullCollection() {
- final TreeSet<E> set = new TreeSet<>();
- set.addAll(Arrays.asList(getFullElements()));
+ final TreeSet<E> set = new TreeSet<>(Arrays.asList(getFullElements()));
return (UnmodifiableSortedSet<E>)
UnmodifiableSortedSet.unmodifiableSortedSet(set);
}
