This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-codec.git


The following commit(s) were added to refs/heads/master by this push:
     new 56c0a12  Use isEmpty().
56c0a12 is described below

commit 56c0a128fdc4f09b21b0febc4fde749d31283319
Author: Gary Gregory <[email protected]>
AuthorDate: Sun Jan 17 09:42:20 2021 -0500

    Use isEmpty().
---
 src/main/java/org/apache/commons/codec/language/ColognePhonetic.java  | 4 ++--
 src/main/java/org/apache/commons/codec/language/bm/Languages.java     | 2 +-
 .../org/apache/commons/codec/language/bm/BeiderMorseEncoderTest.java  | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git 
a/src/main/java/org/apache/commons/codec/language/ColognePhonetic.java 
b/src/main/java/org/apache/commons/codec/language/ColognePhonetic.java
index 3555e8e..049de1f 100644
--- a/src/main/java/org/apache/commons/codec/language/ColognePhonetic.java
+++ b/src/main/java/org/apache/commons/codec/language/ColognePhonetic.java
@@ -328,10 +328,10 @@ public class ColognePhonetic implements StringEncoder {
         char lastChar = CHAR_IGNORE;
         char chr;
 
-        while (input.length() > 0) {
+        while (!input.isEmpty()) {
             chr = input.removeNext();
 
-            if (input.length() > 0) {
+            if (!input.isEmpty()) {
                 nextChar = input.getNextChar();
             } else {
                 nextChar = CHAR_IGNORE;
diff --git a/src/main/java/org/apache/commons/codec/language/bm/Languages.java 
b/src/main/java/org/apache/commons/codec/language/bm/Languages.java
index 999acb9..778b072 100644
--- a/src/main/java/org/apache/commons/codec/language/bm/Languages.java
+++ b/src/main/java/org/apache/commons/codec/language/bm/Languages.java
@@ -184,7 +184,7 @@ public class Languages {
                 } else {
                     if (line.startsWith(ResourceConstants.EXT_CMT_START)) {
                         inExtendedComment = true;
-                    } else if (line.length() > 0) {
+                    } else if (!line.isEmpty()) {
                         ls.add(line);
                     }
                 }
diff --git 
a/src/test/java/org/apache/commons/codec/language/bm/BeiderMorseEncoderTest.java
 
b/src/test/java/org/apache/commons/codec/language/bm/BeiderMorseEncoderTest.java
index ee6444a..629c9ce 100644
--- 
a/src/test/java/org/apache/commons/codec/language/bm/BeiderMorseEncoderTest.java
+++ 
b/src/test/java/org/apache/commons/codec/language/bm/BeiderMorseEncoderTest.java
@@ -147,7 +147,7 @@ public class BeiderMorseEncoderTest extends 
StringEncoderAbstractTest<StringEnco
         encoder.setMaxPhonemes(10);
 
         final String phonemes = encoder.encode(phrase);
-        assertTrue(phonemes.length() > 0);
+        assertFalse(phonemes.isEmpty());
 
         final String[] phonemeArr = phonemes.split("\\|");
         assertTrue(phonemeArr.length <= 10);

Reply via email to