This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-validator.git


The following commit(s) were added to refs/heads/master by this push:
     new 224b136  Use isEmpty().
224b136 is described below

commit 224b1361920304f383d572e23a4e2423884a3847
Author: Gary Gregory <[email protected]>
AuthorDate: Sun Jan 17 10:36:29 2021 -0500

    Use isEmpty().
---
 src/main/java/org/apache/commons/validator/DateValidator.java    | 2 +-
 src/main/java/org/apache/commons/validator/EmailValidator.java   | 2 +-
 src/main/java/org/apache/commons/validator/GenericValidator.java | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/main/java/org/apache/commons/validator/DateValidator.java 
b/src/main/java/org/apache/commons/validator/DateValidator.java
index 9a9840d..af42a00 100644
--- a/src/main/java/org/apache/commons/validator/DateValidator.java
+++ b/src/main/java/org/apache/commons/validator/DateValidator.java
@@ -71,7 +71,7 @@ public class DateValidator {
 
         if (value == null
                 || datePattern == null
-                || datePattern.length() <= 0) {
+                || datePattern.isEmpty()) {
 
             return false;
         }
diff --git a/src/main/java/org/apache/commons/validator/EmailValidator.java 
b/src/main/java/org/apache/commons/validator/EmailValidator.java
index 4cd2101..cf29f6b 100644
--- a/src/main/java/org/apache/commons/validator/EmailValidator.java
+++ b/src/main/java/org/apache/commons/validator/EmailValidator.java
@@ -140,7 +140,7 @@ public class EmailValidator {
         Matcher ipAddressMatcher = IP_DOMAIN_PATTERN.matcher(ipAddress);
         for (int i = 1; i <= 4; i++) { // CHECKSTYLE IGNORE MagicNumber
             String ipSegment = ipAddressMatcher.group(i);
-            if (ipSegment == null || ipSegment.length() <= 0) {
+            if (ipSegment == null || ipSegment.isEmpty()) {
                 return false;
             }
 
diff --git a/src/main/java/org/apache/commons/validator/GenericValidator.java 
b/src/main/java/org/apache/commons/validator/GenericValidator.java
index 904892e..a2baef2 100644
--- a/src/main/java/org/apache/commons/validator/GenericValidator.java
+++ b/src/main/java/org/apache/commons/validator/GenericValidator.java
@@ -64,7 +64,7 @@ public class GenericValidator implements Serializable {
      * @return true if matches the regular expression.
      */
     public static boolean matchRegexp(String value, String regexp) {
-        if (regexp == null || regexp.length() <= 0) {
+        if (regexp == null || regexp.isEmpty()) {
             return false;
         }
 

Reply via email to