[commons-lang] branch master updated: Minor Improvements (#701)

[ggregory]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-lang.git


The following commit(s) were added to refs/heads/master by this push:
     new 02ff51e  Minor Improvements (#701)
02ff51e is described below

commit 02ff51e50401e43dc7101b57e5f2306a8bcb7eee
Author: Arturo Bernal <arturobern...@gmail.com>
AuthorDate: Wed Feb 10 23:16:02 2021 +0100

    Minor Improvements (#701)
    
    * Minor Improvement:
    
    * Add final variable.try to make the code read-only
    * inline Variable. Simplify code
    
    * Update UnicodeUnpairedSurrogateRemover.java
    
    Better comment.
    
    Co-authored-by: Gary Gregory <garydgreg...@users.noreply.github.com>
---
 .../lang3/text/translate/UnicodeUnpairedSurrogateRemover.java      | 7 ++-----
 src/main/java/org/apache/commons/lang3/time/FastDateParser.java    | 4 ++--
 2 files changed, 4 insertions(+), 7 deletions(-)

diff --git 
a/src/main/java/org/apache/commons/lang3/text/translate/UnicodeUnpairedSurrogateRemover.java
 
b/src/main/java/org/apache/commons/lang3/text/translate/UnicodeUnpairedSurrogateRemover.java
index 0115422..b171f7e 100644
--- 
a/src/main/java/org/apache/commons/lang3/text/translate/UnicodeUnpairedSurrogateRemover.java
+++ 
b/src/main/java/org/apache/commons/lang3/text/translate/UnicodeUnpairedSurrogateRemover.java
@@ -34,12 +34,9 @@ public class UnicodeUnpairedSurrogateRemover extends 
CodePointTranslator {
      */
     @Override
     public boolean translate(final int codepoint, final Writer out) throws 
IOException {
-        if (codepoint >= Character.MIN_SURROGATE && codepoint <= 
Character.MAX_SURROGATE) {
-            // It's a surrogate. Write nothing and say we've translated.
-            return true;
-        }
+        // true: It's a surrogate. Write nothing and say we've translated.
+        return codepoint >= Character.MIN_SURROGATE && codepoint <= 
Character.MAX_SURROGATE;
         // It's not a surrogate. Don't translate it.
-        return false;
     }
 }
 
diff --git a/src/main/java/org/apache/commons/lang3/time/FastDateParser.java 
b/src/main/java/org/apache/commons/lang3/time/FastDateParser.java
index 9ae683b..b8db4d7 100644
--- a/src/main/java/org/apache/commons/lang3/time/FastDateParser.java
+++ b/src/main/java/org/apache/commons/lang3/time/FastDateParser.java
@@ -820,8 +820,8 @@ public class FastDateParser implements DateParser, 
Serializable {
         private final Map<String, TzInfo> tzNames= new HashMap<>();
 
         private static class TzInfo {
-            TimeZone zone;
-            int dstOffset;
+            final TimeZone zone;
+            final int dstOffset;
 
             TzInfo(final TimeZone tz, final boolean useDst) {
                 zone = tz;