This is an automated email from the ASF dual-hosted git repository. aherbert pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-rng.git
commit 8b36169a1316fdd05dad00affb3c8f1901d66ac3 Author: Alex Herbert <[email protected]> AuthorDate: Thu Mar 17 21:57:19 2022 +0000 Fix PMD errors --- .../java/org/apache/commons/rng/simple/internal/Conversions.java | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/commons-rng-simple/src/main/java/org/apache/commons/rng/simple/internal/Conversions.java b/commons-rng-simple/src/main/java/org/apache/commons/rng/simple/internal/Conversions.java index 4f2ea9d..9b51daf 100644 --- a/commons-rng-simple/src/main/java/org/apache/commons/rng/simple/internal/Conversions.java +++ b/commons-rng-simple/src/main/java/org/apache/commons/rng/simple/internal/Conversions.java @@ -106,12 +106,13 @@ final class Conversions { * * <p>This is ranked first of the top 14 Stafford mixers. * - * @param x the input value + * @param z the input value * @return the output value * @see <a href="http://zimbry.blogspot.com/2011/09/better-bit-mixing-improving-on.html";>Better * Bit Mixing - Improving on MurmurHash3's 64-bit Finalizer.</a> */ - private static long stafford13(long x) { + private static long stafford13(long z) { + long x = z; x = (x ^ (x >>> 30)) * 0xbf58476d1ce4e5b9L; x = (x ^ (x >>> 27)) * 0x94d049bb133111ebL; return x ^ (x >>> 31); @@ -182,7 +183,7 @@ final class Conversions { // Process pairs final int n = length & ~0x1; for (int i = 0; i < n; i += 2) { - long x = stafford13(v += GOLDEN_RATIO); + final long x = stafford13(v += GOLDEN_RATIO); output[i] = (int) x; output[i + 1] = (int) (x >>> 32); }
