[commons-codec] branch master updated: Avoid use toString() or substring()in favor of a simplified expression. (#126)

[ggregory]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-codec.git


The following commit(s) were added to refs/heads/master by this push:
     new 8993f9a6 Avoid use toString() or substring()in favor of a simplified 
expression. (#126)
8993f9a6 is described below

commit 8993f9a645d740dc5105443cdfd7277df243b7a3
Author: Arturo Bernal <arturobern...@gmail.com>
AuthorDate: Sun Apr 17 15:14:04 2022 +0200

    Avoid use toString() or substring()in favor of a simplified expression. 
(#126)
---
 src/main/java/org/apache/commons/codec/language/DoubleMetaphone.java  | 4 ++--
 .../java/org/apache/commons/codec/language/bm/PhoneticEngine.java     | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git 
a/src/main/java/org/apache/commons/codec/language/DoubleMetaphone.java 
b/src/main/java/org/apache/commons/codec/language/DoubleMetaphone.java
index b04a1cb7..3771f02d 100644
--- a/src/main/java/org/apache/commons/codec/language/DoubleMetaphone.java
+++ b/src/main/java/org/apache/commons/codec/language/DoubleMetaphone.java
@@ -972,7 +972,7 @@ public class DoubleMetaphone implements StringEncoder {
             if (value.length() <= addChars) {
                 this.primary.append(value);
             } else {
-                this.primary.append(value.substring(0, addChars));
+                this.primary.append(value, 0, addChars);
             }
         }
 
@@ -981,7 +981,7 @@ public class DoubleMetaphone implements StringEncoder {
             if (value.length() <= addChars) {
                 this.alternate.append(value);
             } else {
-                this.alternate.append(value.substring(0, addChars));
+                this.alternate.append(value, 0, addChars);
             }
         }
 
diff --git 
a/src/main/java/org/apache/commons/codec/language/bm/PhoneticEngine.java 
b/src/main/java/org/apache/commons/codec/language/bm/PhoneticEngine.java
index 3f58b856..4ae2c618 100644
--- a/src/main/java/org/apache/commons/codec/language/bm/PhoneticEngine.java
+++ b/src/main/java/org/apache/commons/codec/language/bm/PhoneticEngine.java
@@ -403,7 +403,7 @@ public class PhoneticEngine {
         input = input.toLowerCase(Locale.ENGLISH).replace('-', ' ').trim();
 
         if (this.nameType == NameType.GENERIC) {
-            if (input.length() >= 2 && input.substring(0, 2).equals("d'")) { 
// check for d'
+            if (input.length() >= 2 && input.startsWith("d'")) { // check for 
d'
                 final String remainder = input.substring(2);
                 final String combined = "d" + remainder;
                 return "(" + encode(remainder) + ")-(" + encode(combined) + 
")";