This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-beanutils.git
commit 6b37fae6324c6313e0f3d71e10a450f54d99f3d8 Author: Gary Gregory <[email protected]> AuthorDate: Thu Apr 21 19:02:31 2022 -0400 Fix SpotBugs error. [ERROR] Medium: Load of known null value in org.apache.commons.beanutils2.converters.AbstractConverter.convert(Class, Object) [org.apache.commons.beanutils2.converters.AbstractConverter] At AbstractConverter.java:[line 163] NP_LOAD_OF_KNOWN_NULL_VALUE --- src/changes/changes.xml | 3 +++ .../commons/beanutils2/converters/AbstractConverter.java | 13 +++++-------- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/changes/changes.xml b/src/changes/changes.xml index c374f3f9..bee93f32 100644 --- a/src/changes/changes.xml +++ b/src/changes/changes.xml @@ -80,6 +80,9 @@ <action dev="ggregory" type="fix" due-to="Gary Gregory"> Fix SpotBugs [ERROR] Medium: org.apache.commons.beanutils2.BasicDynaClass.constructorTypes should be both final and package protected [org.apache.commons.beanutils2.BasicDynaClass] At BasicDynaClass.java:[line 95] MS_FINAL_PKGPROTECT. </action> + <action dev="ggregory" type="fix" due-to="Gary Gregory"> + Fix SpotBugs [ERROR] Medium: Load of known null value in org.apache.commons.beanutils2.converters.AbstractConverter.convert(Class, Object) [org.apache.commons.beanutils2.converters.AbstractConverter] At AbstractConverter.java:[line 163] NP_LOAD_OF_KNOWN_NULL_VALUE. + </action> <!-- UPDATES --> <action dev="ggregory" type="update" due-to="Dependabot, Gary Gregory"> Bump actions/cache from 2 to 3.0.2 #77, #89, #103, #111. diff --git a/src/main/java/org/apache/commons/beanutils2/converters/AbstractConverter.java b/src/main/java/org/apache/commons/beanutils2/converters/AbstractConverter.java index af44f888..b1a4a733 100644 --- a/src/main/java/org/apache/commons/beanutils2/converters/AbstractConverter.java +++ b/src/main/java/org/apache/commons/beanutils2/converters/AbstractConverter.java @@ -160,7 +160,7 @@ public abstract class AbstractConverter implements Converter { public <T> T convert(final Class<T> type, Object value) { if (type == null) { - return convertToDefaultType(type, value); + return convertToDefaultType(value); } Class<?> sourceType = value == null ? null : value.getClass(); @@ -244,17 +244,14 @@ public abstract class AbstractConverter implements Converter { * not have a target class. In this case, the T parameter is not set. * Therefore, we can cast to it (which is required to fulfill the contract * of the method signature). + * @param value the value to be converted * * @param <T> the type of the result object - * @param targetClass the target class of the conversion - * @param value the value to be converted * @return the converted value */ - private <T> T convertToDefaultType(final Class<T> targetClass, final Object value) { - @SuppressWarnings("unchecked") - final - T result = (T) convert(getDefaultType(), value); - return result; + @SuppressWarnings("unchecked") + private <T> T convertToDefaultType(final Object value) { + return (T) convert(getDefaultType(), value); } /**
