[commons-io] branch master updated: Simplify test fixture creation

[ggregory]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-io.git


The following commit(s) were added to refs/heads/master by this push:
     new 6efad791 Simplify test fixture creation
6efad791 is described below

commit 6efad7916c68a34258b1ea2c866420fce23d529b
Author: Gary Gregory <gardgreg...@gmail.com>
AuthorDate: Wed Jun 15 07:10:14 2022 -0400

    Simplify test fixture creation
---
 .../io/input/MemoryMappedFileInputStreamTest.java        | 16 ++++++----------
 1 file changed, 6 insertions(+), 10 deletions(-)

diff --git 
a/src/test/java/org/apache/commons/io/input/MemoryMappedFileInputStreamTest.java
 
b/src/test/java/org/apache/commons/io/input/MemoryMappedFileInputStreamTest.java
index f1c8465c..338fefbb 100644
--- 
a/src/test/java/org/apache/commons/io/input/MemoryMappedFileInputStreamTest.java
+++ 
b/src/test/java/org/apache/commons/io/input/MemoryMappedFileInputStreamTest.java
@@ -19,10 +19,8 @@ package org.apache.commons.io.input;
 import static org.junit.jupiter.api.Assertions.assertArrayEquals;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 
-import java.io.BufferedOutputStream;
 import java.io.IOException;
 import java.io.InputStream;
-import java.io.OutputStream;
 import java.nio.file.Files;
 import java.nio.file.Path;
 import java.util.Arrays;
@@ -41,6 +39,8 @@ import org.junit.jupiter.params.provider.ValueSource;
  */
 public class MemoryMappedFileInputStreamTest {
 
+    private static final byte[] EMPTY_BYTE_ARRAY = new byte[0];
+
     @TempDir
     Path tempDir;
 
@@ -53,11 +53,7 @@ public class MemoryMappedFileInputStreamTest {
     }
 
     private Path createTestFile(final int size) throws IOException {
-        final Path file = Files.createTempFile(tempDir, null, null);
-        try (OutputStream outputStream = new 
BufferedOutputStream(Files.newOutputStream(file))) {
-            Files.write(file, RandomUtils.nextBytes(size));
-        }
-        return file;
+        return Files.write(Files.createTempFile(tempDir, null, null), 
RandomUtils.nextBytes(size));
     }
 
     @Test
@@ -80,7 +76,7 @@ public class MemoryMappedFileInputStreamTest {
         // test
         try (InputStream inputStream = new MemoryMappedFileInputStream(file)) {
             // verify
-            assertArrayEquals(new byte[0], IOUtils.toByteArray(inputStream));
+            assertArrayEquals(EMPTY_BYTE_ARRAY, 
IOUtils.toByteArray(inputStream));
         }
     }
 
@@ -148,7 +144,7 @@ public class MemoryMappedFileInputStreamTest {
         try (InputStream inputStream = new MemoryMappedFileInputStream(file)) {
             assertEquals(0, inputStream.skip(5));
             // verify
-            assertArrayEquals(new byte[0], IOUtils.toByteArray(inputStream));
+            assertArrayEquals(EMPTY_BYTE_ARRAY, 
IOUtils.toByteArray(inputStream));
         }
     }
 
@@ -208,7 +204,7 @@ public class MemoryMappedFileInputStreamTest {
             IOUtils.toByteArray(inputStream, 5);
             assertEquals(95, inputStream.skip(96));
             // verify
-            assertArrayEquals(new byte[0], IOUtils.toByteArray(inputStream));
+            assertArrayEquals(EMPTY_BYTE_ARRAY, 
IOUtils.toByteArray(inputStream));
         }
     }