This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-dbcp.git

commit ad18ca916f227b13b92f73108566cb7a01450633
Author: Gary Gregory <[email protected]>
AuthorDate: Sun Jul 3 08:33:55 2022 -0400

    Call addObjects(int) instead of looping over addObject()
---
 src/main/java/org/apache/commons/dbcp2/BasicDataSource.java | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/main/java/org/apache/commons/dbcp2/BasicDataSource.java 
b/src/main/java/org/apache/commons/dbcp2/BasicDataSource.java
index ef359318..5ab69d4c 100644
--- a/src/main/java/org/apache/commons/dbcp2/BasicDataSource.java
+++ b/src/main/java/org/apache/commons/dbcp2/BasicDataSource.java
@@ -567,9 +567,7 @@ public class BasicDataSource implements DataSource, 
BasicDataSourceMXBean, MBean
 
             // If initialSize > 0, preload the pool
             try {
-                for (int i = 0; i < initialSize; i++) {
-                    connectionPool.addObject();
-                }
+                connectionPool.addObjects(initialSize);
             } catch (final Exception e) {
                 closeConnectionPool();
                 throw new SQLException("Error preloading the connection pool", 
e);

Reply via email to