kezhuw commented on code in PR #497: URL: https://github.com/apache/curator/pull/497#discussion_r1520792175
########## curator-client/src/main/java/org/apache/curator/utils/ZookeeperCompatibility.java: ########## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.curator.utils; + +/** + * Describe feature supports based on server compatibility (as opposed to {@code Compatibility} + * which represents client compatibility. + */ +public interface ZookeeperCompatibility { + public enum Version implements ZookeeperCompatibility { + VERSION_3_5(false), Review Comment: I guess we probably are pursuing something similar to [`ClientBuilder::assume_server_version`](https://docs.rs/zookeeper-client/0.6.2/zookeeper_client/struct.ClientBuilder.html#method.assume_server_version)(I am the author). My thought was that client library know server compatibility(capabilities, bugs and etc.) given a server version. So, I think it is Curator's responsibility to build the compatibility matrix and do the dirty work but not the caller. I think we probably need only a server version (the class and the `LATEST`) in api side. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@curator.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
