kezhuw commented on code in PR #497: URL: https://github.com/apache/curator/pull/497#discussion_r1523578958
########## curator-client/src/main/java/org/apache/curator/utils/ZookeeperCompatibility.java: ########## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.curator.utils; + +/** + * Describe feature supports based on server compatibility (as opposed to {@code Compatibility} + * which represents client compatibility. + */ +public interface ZookeeperCompatibility { + public enum Version implements ZookeeperCompatibility { + VERSION_3_5(false), Review Comment: Apologize for this! @laurentgo I do agree with @eolivelli that enumerate zookeeper version is not good. > as permanent watchers seems to be the only feature we are checking for I am not sure about this. > asking the user to provide the full version may be overly complicating things as the only version we currently care about is 3.5 vs 3.6/3.7/3.8 Yes, a bit. I guess I have same worry about this. But it is a one for all in api side. That is there will be no new feature toggle apis in future. All features could derive from that version and thus implementation detail. Given all the candidates(feature enum, feature builder and version class), I prefer to a version class currently. Any idea ? @eolivelli @tisonkun -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@curator.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
