mbeckerle commented on a change in pull request #326: Daffodil 1444 cleanup -
removes backpointers and factory patterns no longer needed
URL: https://github.com/apache/incubator-daffodil/pull/326#discussion_r393355465
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/grammar/BitOrderMixin.scala
##########
@@ -45,34 +45,36 @@ trait BitOrderMixin extends GrammarMixin with
ByteOrderAnalysisMixin { self: Ter
*
* If uncertain, returns false.
*/
- final protected lazy val isKnownSameBitOrder: Boolean = {
- val res =
- if (enclosingTerm.isEmpty) false // root needs bit order
- else {
- val optPrior =
this.nearestPriorPhysicalTermSatisfying(_.optDefaultBitOrder.isDefined)
- optPrior match {
- case None => false // no prior that has a bit order we could be the
same as
- case Some(prior) => {
- if (prior.defaultBitOrder =:= this.defaultBitOrder) true
- else false
- }
- }
- }
- res
- }
+ final protected lazy val isKnownSameBitOrder: Boolean = false // FIXME: must
analyze prior terms, enclosing terms, etc.
Review comment:
Missed this. Need to investigate if this disables an important optimization.
This file was converted to stubs and needs to be reconsidered.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
