stevedlawrence commented on a change in pull request #326: Daffodil 2280
cleanup - removes backpointers and factory patterns no longer needed
URL: https://github.com/apache/incubator-daffodil/pull/326#discussion_r393636432
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/dsom/ElementBase.scala
##########
@@ -288,7 +291,10 @@ trait ElementBase
}
}
- private lazy val parentMinimizedScope = enclosingElement.map {
_.minimizedScope }.getOrElse(scala.xml.TopScope)
+ private lazy val parentMinimizedScope = {
+ val ee = enclosingElements.headOption // FIXME: doesn't work unless all
are same.
Review comment:
Same question here, is this broken?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
