olabusayoT commented on a change in pull request #326: Daffodil 2280 cleanup -
removes backpointers and factory patterns no longer needed
URL: https://github.com/apache/incubator-daffodil/pull/326#discussion_r394545238
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/dsom/ModelGroup.scala
##########
@@ -357,7 +349,7 @@ abstract class ModelGroup(index: Int)
// follow it
Seq(e) ++ e.possibleNextSiblingTerms
}
- case Some(s: SequenceTermBase) if s.isHidden =>
s.possibleNextSiblingTerms
+ case Some(s: SequenceTermBase) if s.isHiddenGroupRef =>
s.possibleNextSiblingTerms
Review comment:
if we remove isHiddenGroupRef from ModelGroup, are we ok to replace this
with GroupRef? Presumably this is only ever true for a group ref anyways, so
this could become Some(gr: GroupRef) with the isHidden changes?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
