olabusayoT commented on a change in pull request #326: Daffodil 2280 cleanup -
removes backpointers and factory patterns no longer needed
URL: https://github.com/apache/incubator-daffodil/pull/326#discussion_r393725391
##########
File path:
daffodil-cli/src/it/scala/org/apache/daffodil/saving/TestCLISaveParser.scala
##########
@@ -189,11 +189,13 @@ class TestCLISaveParser {
shell.sendLine(String.format("%s -vv save-parser -s %s -r matrix %s",
Util.binPath, testSchemaFile, savedParserFile.getName()))
shell.expect(contains("[compile]"))
- shell.sendLine(String.format("%s -vvv save-parser -s %s -r matrix %s",
Util.binPath, testSchemaFile, savedParserFile.getName()))
- shell.expect(contains("[debug]"))
+ // Too much output
+ // shell.sendLine(String.format("%s -vvv save-parser -s %s -r matrix
%s", Util.binPath, testSchemaFile, savedParserFile.getName()))
+ // shell.expect(contains("[debug]"))
- shell.sendLine(String.format("%s -vvvv save-parser -s %s -r matrix %s",
Util.binPath, testSchemaFile, savedParserFile.getName()))
- shell.expect(contains("[oolagdebug]"))
+ // Too much output
+ // shell.sendLine(String.format("%s -vvvv save-parser -s %s -r matrix
%s", Util.binPath, testSchemaFile, savedParserFile.getName()))
+ // shell.expect(contains("[oolagdebug]"))
Review comment:
Also rather than commenting out, it'd be ideal to just remove them if we
don't want them anymore
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
