mbeckerle commented on a change in pull request #371:
URL: https://github.com/apache/incubator-daffodil/pull/371#discussion_r415856737
##########
File path:
daffodil-io/src/main/scala/org/apache/daffodil/processors/charset/CharsetUtils.scala
##########
@@ -271,11 +271,7 @@ trait EncoderDecoderMixin
val truncString = cb.toString()
truncString
}
- case _ if cr.isMalformed() => {
- cr.throwException()
- ""
- }
- case _ if cr.isUnmappable() => {
+ case _ if cr.isMalformed() || cr.isUnmappable=> {
cr.throwException()
""
Review comment:
cr.throwException's type is wrong if these clauses need this "" at the
end. cr.throwException() should have return type Nothing, which should be fine
as the return type.
##########
File path: sonar-project.properties
##########
@@ -19,6 +19,8 @@ sonar.projectKey=apache_incubator-daffodil
sonar.modules=daffodil-cli,daffodil-core,daffodil-io,daffodil-japi,daffodil-lib,daffodil-macro-lib,daffodil-propgen,daffodil-runtime1,daffodil-runtime1-unparser,daffodil-sapi,daffodil-tdml-lib,daffodil-tdml-processor,daffodil-test,daffodil-test-ibm1,daffodil-udf
sonar.sources=src/main
sonar.tests=src/it,src/test
+# Scala/Java APIs contain a lot of duplication by their nature. Best to
exclude them.
Review comment:
There's a JIRA ticket DAFFODIL-1747 which, when fixed, will want to
revisit this statement.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
