olabusayoT commented on a change in pull request #371:
URL: https://github.com/apache/incubator-daffodil/pull/371#discussion_r415895785
##########
File path:
daffodil-io/src/main/scala/org/apache/daffodil/processors/charset/CharsetUtils.scala
##########
@@ -271,11 +271,7 @@ trait EncoderDecoderMixin
val truncString = cb.toString()
truncString
}
- case _ if cr.isMalformed() => {
- cr.throwException()
- ""
- }
- case _ if cr.isUnmappable() => {
+ case _ if cr.isMalformed() || cr.isUnmappable=> {
cr.throwException()
""
Review comment:
I didn't find this to be the case. This match is used to build a string,
so not having every case return a string leads to s Type Mismatch Error
(Required String, Found Unit).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
