stevedlawrence commented on pull request #505: URL: https://github.com/apache/daffodil/pull/505#issuecomment-829360951
Actually, I just needed to add a list copy on two members instead of just one. Looking at DPathCompileInfo we actually already do a copy for the typeCalcMap to get around a serialization issue, I'm not sure if it's related: https://github.com/apache/daffodil/blob/master/daffodil-runtime1/src/main/scala/org/apache/daffodil/dsom/CompiledExpression1.scala#L271-L274 But it does imply there are some issues with serialization in Scala. I've pushed a fix that shows the new ``map(identity)``'s that fixes this particular issue. I still don't know what changed in 2.12.12 to make this test start failing now, but I honestly don't understand why this didn't happen in 2.12.11. When I run that minimal reproducable snippet above in scala 2.12.11 then it does fail. So I think this List serialization thing is an issue with all versions of 2.12, and we just happened to get lucky and not hit it in any of our tests. So I would say the map is an important fix to deal with some serializtion edge cases to probably exist currently. And if that does fix these issues, which it seems to do, upgrading scala to the 2.12.13 probably includes other fixes we should have. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
