stevedlawrence opened a new pull request, #1070: URL: https://github.com/apache/daffodil/pull/1070
This removes the dfdlx:inputTypeCalc and dfdlx:outputTypeCalc properties and DPath functions. This allows for removal of a number of related member variables and functions used only by the expression type calc functions. For example, the typeCalcMap is only used by the functions to lookup a calculator by QName at runtime. All type calculators are known statically at compile time, so everything related to runtime type calculator maps goes away. Also does some minor refactoring: - Moves code around so similar logic is all in one place or removes conditionals - Changes a tuple where only element has a meaningful value to an Either so we enforce that restriction - Fixes typo in IdentityTypeCalc name - Changes some error messages so they are a bit more less developer centric DAFFODIL-2211 ---- Note that this is only part of of DAFFODIL-2211. I'm making this a separate PR so it's more clear which parts are about removing input/outputValueCalc and which parts are about updating the diagnostics. It also means if we ever want to bring back typeValueCalc, we can just revert this PR without undoing the diagnostic changes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
