tuxji commented on code in PR #1070:
URL: https://github.com/apache/daffodil/pull/1070#discussion_r1298603950
##########
daffodil-runtime1/src/main/scala/org/apache/daffodil/runtime1/processors/TypeCalculator.scala:
##########
@@ -40,116 +35,72 @@ abstract class TypeCalculator(val srcType: NodeInfo.Kind,
val dstType: NodeInfo.
extends Serializable {
Review Comment:
I would also add a scaladoc comment to this class giving an overview of what
type calculations are used for in Daffodil schema compilation.
##########
daffodil-core/src/main/scala/org/apache/daffodil/core/dsom/SimpleTypes.scala:
##########
@@ -312,40 +308,49 @@ abstract class SimpleTypeDefBase(xml: Node,
lexicalParent: SchemaComponent)
}
}
- lazy val optInputTypeCalc = findPropertyOption("inputTypeCalc",
expressionAllowed = true)
- lazy val optOutputTypeCalc = findPropertyOption("outputTypeCalc",
expressionAllowed = true)
-
lazy val optTypeCalculator: Option[TypeCalculator] = LV('optTypeCalculator) {
Review Comment:
I haven't read about type calculations before your PR. Please add a comment
here explaining what a type calculator does for DFDL schema compilation. I see
5 uses of optTypeCalculator in my checkout and 2 uses left in your branch, so I
wonder what prevented you from simply removing everything to do with type
calculations (although I assume they have something to do with reptypes).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
