stevedlawrence commented on code in PR #1122:
URL: https://github.com/apache/daffodil/pull/1122#discussion_r1408288320
##########
daffodil-core/src/main/scala/org/apache/daffodil/core/compiler/Compiler.scala:
##########
@@ -92,13 +89,10 @@ final class ProcessorFactory private (
validateDFDLSchemas,
checkAllTopLevel,
tunables,
- Some(sset),
Review Comment:
This line is the core issue, where we copy the current incorrect schema set
into the new ProcessorFactory.
All the other stuff is related to isErrors, which avoids work that may not
be needed. The downside is that work won't happen until a user calls isError,
which is potentially confusing. It also means were are more strict about
isError being called before other functions. Maybe this is controversial and
should be backed out?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
