tuxji commented on code in PR #1122:
URL: https://github.com/apache/daffodil/pull/1122#discussion_r1409360255
##########
daffodil-core/src/main/scala/org/apache/daffodil/core/compiler/Compiler.scala:
##########
@@ -92,13 +89,10 @@ final class ProcessorFactory private (
validateDFDLSchemas,
checkAllTopLevel,
tunables,
- Some(sset),
Review Comment:
> There is maybe an argument that if a user calls getDiagnostics then they
aren't planning on calling any more withXYZ functions and we should just call
isError for them so they get the right result. This would mean calling isError
or getDiagnostics will trigger work.
I find your argument persuasive. Let's trigger the work in both isError and
getDiagnostics as you suggest.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
