stevedlawrence commented on code in PR #1237:
URL: https://github.com/apache/daffodil/pull/1237#discussion_r1601527497


##########
build.sbt:
##########
@@ -412,15 +415,48 @@ lazy val ratSettings = Seq(
   ratFailBinaries := true
 )
 
+/**
+ * Used on projects where we want javadoc even though the code is written in 
scala.
+ */
+def withScalaDocConvertedToJavaDoc(p: Project): Project = {
+  p.enablePlugins(GenJavadocPlugin)
+    .settings(unidocGenjavadocVersion := Dependencies.genjavadoc)
+}

Review Comment:
   I think we could actually just move the unidocGenjavadocVersion setting to 
commonSettings, then any projects that enable GenJavadocPlugin will 
automatically get it. And since enablePlugins is the only thing this does, we 
can just move `enablePlugins(GenJavadocPlugin)` to the individual projects.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to