stevedlawrence commented on code in PR #1237:
URL: https://github.com/apache/daffodil/pull/1237#discussion_r1601532344
##########
build.sbt:
##########
@@ -429,12 +465,15 @@ lazy val unidocSettings = Seq(
"-notimestamp",
"-quiet"
),
- JavaUnidoc / unidoc / unidocAllSources := (JavaUnidoc / unidoc /
unidocAllSources).value.map {
- sources =>
- sources.filterNot { source =>
- source.toString.contains("$") ||
source.toString.contains("packageprivate")
+ JavaUnidoc / unidoc / unidocAllSources :=
+ (JavaUnidoc / unidoc / unidocAllSources).value
+ .map(apiDocSourceFilter(_))
+ .map {
+ _.filterNot { source =>
+ // For JAPI so that some things are excluded from the javadoc
because they are internal
+ source.toString.contains("$") ||
source.toString.contains("packageprivate")
Review Comment:
Could we move these to the `excluded` check in apiSourceDocFilter? No scala
files have dollar signs or "packageprivate" in them so it shouldn't affect
scala docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
