stevedlawrence commented on code in PR #1314:
URL: https://github.com/apache/daffodil/pull/1314#discussion_r1773643459
##########
daffodil-lib/src/main/scala/org/apache/daffodil/lib/xml/QNameBase.scala:
##########
@@ -581,9 +585,9 @@ object RefQNameFactory extends
RefQNameFactoryBase[RefQName] {
val resolvedNS = (preNS, ns) match {
case (None, UnspecifiedNamespace) => {
// if neither prefix nor namespace was specified, use the default
namespace (i.e.
- // xmln="...") if defined. If not defined, use the targetNamespace.
+ // xmlns="...") if defined. If not defined, use the noPrefixNamespace.
val defaultNS = resolveDefaultNamespace(scope,
unqualifiedPathStepPolicy)
- defaultNS.map(NS(_)).getOrElse(targetNamespace)
+ defaultNS.getOrElse(noPrefixNamespace)
Review Comment:
This entire function has zero coverage and is not used anywhere. This is
just dead code that I think we should probably just remove.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
