stevedlawrence commented on code in PR #1314: URL: https://github.com/apache/daffodil/pull/1314#discussion_r1773679415
########## daffodil-core/src/main/scala/org/apache/daffodil/core/grammar/GrammarTerm.scala: ########## @@ -56,7 +56,7 @@ abstract class Gram(contextArg: SchemaComponent) final override lazy val tunable = context.tunable final override def namespaces = context.namespaces - final override def targetNamespace = context.targetNamespace + final override def noPrefixNamespace = context.noPrefixNamespace Review Comment: It looks like not only does nothing ask for `noPrefixNamespace` at the level of `Gram` objects, nothing also asks for `namespaces` and `unqualifiedPathStep` policy, two things also needed for resolving references. It looks like codecov only sees no coverage on noPrefixNamespace for some reason. I think what that means is we need to move `ResolvesQNames` to a trait down a level so that is only on a DSOM objects but not any Gram objects. Which I think makes sense? DSOM should be resolving everything and then Grams are created based on those results. I think that means `ResolvesQNames` should be on `SchemaComponent` instead. I'll move it and see what happens. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
