jadams-tresys commented on code in PR #1433:
URL: https://github.com/apache/daffodil/pull/1433#discussion_r1956201036
##########
daffodil-core/src/main/scala/org/apache/daffodil/core/dsom/SimpleTypes.scala:
##########
@@ -276,17 +276,17 @@ final class EnumerationDef(xml: Node, parentType:
SimpleTypeDefBase)
SDE("Invalid data for enumeration: %s", e.getMessage)
}
- lazy val repValuesRaw: Seq[String] = {
+ lazy val repValuesRaw: collection.Seq[String] = {
Review Comment:
This also feels weird that we need to specify collection.Seq instead of just
using Seq.
##########
project/OsgiCheck.scala:
##########
@@ -83,7 +83,7 @@ object OsgiCheckPlugin extends AutoPlugin {
// should be a list of one.
val packageOwnersMap = packageOwnerTuples
.groupBy { case (packageName, _) => packageName }
- .mapValues { list => list.map { case (_, packageOwner) =>
packageOwner } }
+ .map { case (k, list) => k -> list.map { case (_, packageOwner) =>
packageOwner } }
Review Comment:
Thoughts on changing this to something like:
```val packageOwnersMap = packageOwnerTuples
.groupBy { case (packageName, _) => packageName }
.values.map { list => list.map { case (_, packageOwner) =>
packageOwner } }
```
I don't have a strong opinion, but I do think it makes it a little clearer
that we are really only interested in the values of the map.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
