olabusayoT commented on code in PR #1433:
URL: https://github.com/apache/daffodil/pull/1433#discussion_r1956616506


##########
project/OsgiCheck.scala:
##########
@@ -83,7 +83,7 @@ object OsgiCheckPlugin extends AutoPlugin {
         // should be a list of one.
         val packageOwnersMap = packageOwnerTuples
           .groupBy { case (packageName, _) => packageName }
-          .mapValues { list => list.map { case (_, packageOwner) => 
packageOwner } }
+          .map { case (k, list) => k -> list.map { case (_, packageOwner) => 
packageOwner } }

Review Comment:
   > Thoughts on changing this to something like:
   
   So .mapValues iterates over values, but returns the entire map back, which 
is why I went with .map instead of .values.map which doesn't return the entire 
map.
   
   I'll look into the RichMap conversion



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to