JeremyYao commented on issue #1203: URL: https://github.com/apache/daffodil-vscode/issues/1203#issuecomment-3109646045
Reviewed the changes. I like how it gives users a preview of what to expect in a debugging session. Nice job on including screenshots. However, the beginner's guide assumes that users are installing the extension from the marketplace (see the prior steps) instead of running it from Visual Studio code (how developers would). Additionally, I would like to see there not be steps of editing the launch.json and sticking with the default values first for the input data and DFDL schema paths. Setting the check boxes for opening the infoset view, infoset diff, and data editor is fine though for configuring the launch.json config. Also, it would be nice to include sample DFDL schemas and data files to give users an example run-though instead of having to search for a valid DFDL schema and data file. Please reach out if you have any questions on some of my feedback and/or requested changes. Keep up the good work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
