JeremyYao commented on issue #1203: URL: https://github.com/apache/daffodil-vscode/issues/1203#issuecomment-3234585171
Review for https://github.com/apache/daffodil-vscode/wiki/Introduction-to-Daffodil-VS-Code-Extension/f6768a0d78dbd6d38e4a99b77c24c3bafc650032 ### 0 <img width="1289" height="361" alt="Image" src="https://github.com/user-attachments/assets/bdc36ccf-4758-43d8-9b3c-dbfa93e3d390"; /> Reword to `Click on play button to start a DFDL schema debugging session` ### 1 <img width="926" height="416" alt="Image" src="https://github.com/user-attachments/assets/8a8105e9-075a-411f-a433-2723342a83ce"; /> The data editor shouldn't pop up looking at this previous step <img width="974" height="258" alt="Image" src="https://github.com/user-attachments/assets/b9629951-c886-4d69-9ece-231d85ced24a"; /> Maybe it may be worth mentioning and/or including a screenshot of the `Open data editor on debugging start` checked? ### 2 For <img width="1116" height="510" alt="Image" src="https://github.com/user-attachments/assets/f4ec6255-8b81-4e43-b2a1-8a6127f9d391"; /> we'll most likely want the user to edit the launch.json config through the launch config wizard to be consistent with prior steps. Remember that the beginner's guide is for people who are extremely new to IDEs-- they may not be comfortable with JSON files Refer to this prior step as a reference <img width="1262" height="662" alt="Image" src="https://github.com/user-attachments/assets/1f40e107-68e2-48ad-9885-9155044288e6"; /> ### 3 <img width="1261" height="519" alt="Image" src="https://github.com/user-attachments/assets/f7a82907-b338-4773-9835-3dbe3d7c012b"; /> Rephrase to `Run the corresponding DFDL debugging session from the prior step.` ### 4 <img width="1258" height="675" alt="Image" src="https://github.com/user-attachments/assets/85a6739f-94a3-41cf-8877-c7afd1917429"; /> From 7 in https://github.com/apache/daffodil-vscode/issues/1203#issuecomment-3211834554, recall how we aren't selecting a test case but are typing it out in this version of the extension. Could you reword this step to indicate to the user they are typing out the name of the test case? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
