stevedlawrence commented on code in PR #1515:
URL: https://github.com/apache/daffodil/pull/1515#discussion_r2237501429
##########
daffodil-cli/src/main/scala/org/apache/daffodil/cli/Main.scala:
##########
@@ -184,21 +180,21 @@ class CLIConf(arguments: Array[String], stdout:
PrintStream, stderr: PrintStream
s match {
case DefaultArgPattern(name, arg) if Validators.isRegistered(name) =>
- if (doesNotSupportReloadableParsers(name)) {
- null
+ if (Seq(".conf", ".properties").exists(arg.endsWith)) {
+ val is = new FileInputStream(arg)
+ props.load(is)
Review Comment:
I would suggest any API changes want to be done in a separate PR. And we
should have a discussion on different APIs. For example, I could imagine
completely moving the ValidatorFactory stuff entirely behind the scenes, and
API users just call `DataProcessor.withValidator("xerces",
"path/to/schema.dfdl.xsd")` and behind the scenes Daffodil will call
Validator.get.make or whatever it wants. And we just specify that withValidator
can fail if the appropriate arguments/properties aren't provided.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
