olabusayoT commented on code in PR #1515:
URL: https://github.com/apache/daffodil/pull/1515#discussion_r2251925214
##########
daffodil-core/src/main/scala/org/apache/daffodil/runtime1/processors/DataProcessor.scala:
##########
@@ -155,8 +116,7 @@ class DataProcessor(
* @return the serializable object
*/
@throws(classOf[java.io.ObjectStreamException])
- private def writeReplace(): Object =
- new SerializableDataProcessor(ssrd, tunables, variableMap.copy())
+ private def writeReplace(): Object = new DataProcessor(ssrd, tunables,
variableMap.copy())
Review Comment:
Yes tests were failing when I tried to remove it. It complain about the
debugger not being serializable specifically (test testAPI1_A_Full_SavedParser
for example). How do you suggest the users/test deal with that? Like by setting
dp.withDebugger(null)?
Also are you saying we update save/reload to handle debuggers and other none
serializable things as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
