shanedell commented on code in PR #1336:
URL: https://github.com/apache/daffodil-vscode/pull/1336#discussion_r2252213792
##########
src/adapter/activateDaffodilDebug.ts:
##########
@@ -410,13 +425,12 @@ export function activateDaffodilDebug(
.map((obj) => obj.name) as string[]
// dropdown
- return await vscode.window
- .showQuickPick(test_case_names, {
- placeHolder: 'Test Case Name',
- })
- .then((value) => {
- return value // return selected dropdown value
- })
+ // Await showQuickPick directly and return the result
+ const selection = await vscode.window.showQuickPick(test_case_names, {
+ placeHolder: 'Test Case Name',
+ })
+
+ return selection
Review Comment:
@JeremyYao Update your code to do this for the tdmlConfig and config, also
make sure to update `src/classes/tdmlConfig.ts` to use `string` and not
`String.` This would be would also be a good change for the parameters
`runOrDebug` and `tdmlAction`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
